Publish DEPS for Chromium 65.0.3325.88
Incrementing VERSION to 65.0.3325.88
TBR=dimu@chromium.org
Change-Id: Ie9f368fc9519255f843389a0dca8041fd1ffa6f6
Reviewed-on: https://chromium-review.googlesource.com/927645
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#522}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Notify UKM scheduler of RotationFinished.
Bug:812729
TBR=holte@google.com
(cherry picked from commit 0a8bf4c52054b40a9160b0db5031aae34ecbda07)
Change-Id: I418d2b540302805c08f78d63635f394f02fe3ac5
Reviewed-on: https://chromium-review.googlesource.com/922722
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#537131}
Reviewed-on: https://chromium-review.googlesource.com/927750
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#521}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Correctly serialize empty content_type for blobs.
A BlobDataHandle could not have a content_type set, but that should be
treated no different from an empty string, so serialize it as such.
Otherwise this will trigger validation failures causing weird behavior
when for example a blob without a content type is posted on a
MessagePort.
TBR=mek@chromium.org
(cherry picked from commit bb84d169288460af40536ebbe0303cb35f11a5a1)
Bug: 813146
Change-Id: I0a20a6b91391e9aa490a337b93c74f9ab4316e31
Reviewed-on: https://chromium-review.googlesource.com/924338
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#537462}
Reviewed-on: https://chromium-review.googlesource.com/927709
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#520}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[AppCache] Move binding ownership to the profile-owned service.
This change fixes lifetime issues where the mojo service, created with
mojo::MakeStrongBinding, stayed alive after the Profile, AppCache
service, and things like the URLRequestContext have been destroyed.
This is a little scary, as the AppCacheDispatcherHost and general
AppCache code holds lots of raw pointers, and I'm sure this was the
cause of other strange bugs.
Prior to r522566 (when IPCs were converted to Mojo), the dispatcher
object was owned by the RenderProcessHostImpl, and created during
message filter creation. The filters were explicitly destroyed,
which made the lifetime deterministic.
Bug: 800391
Change-Id: Ie56839de3202be5c63080cf31e7a1391eb7ce405
Reviewed-on: https://chromium-review.googlesource.com/922919
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#537144}(cherry picked from commit 00e3063ee402eecd68ee8d32634d9d490050d41d)
Reviewed-on: https://chromium-review.googlesource.com/927664
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#519}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Merge to M65: Android Accessibility: Avoiding crash on unregistering broadcast receiver.
There might be cases where unregistering broadcast receiver can throw
IllegalArgumentException if the context is not handled in an appropriate
manner. This CL avoids the crash.
(cherry picked from commit 8839385d34f511f6498bc20edba638944b67d0cd)
Change-Id: I9d7888dcbde518caa6e7e426a215953e9c3ba672
Bug: 780261
Reviewed-on: https://chromium-review.googlesource.com/891458
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Isha Bobra <ibobra@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#532578}
Reviewed-on: https://chromium-review.googlesource.com/927450
Cr-Commit-Position: refs/branch-heads/3325@{#518}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
m65 merge: cros: fix cannot minimize window after leaving tablet mode
changes:
When leaving tablet mode, we will restore old state, which will finally
call BaseState::UpdateMinimizedState. If a window is minimized at this
time, it will set |aura::client::kPreMinimizedShowStateKey| to
minimized show state. It doesn't make sense to set pre-minimized show
state to minimized show state, which could leave us in a bad window state.
TBR=jamescook@chromium.org
(cherry picked from commit b6f3f2bea1a5b9af6694611cc55c304de265956b)
Bug: 783310, 810857
Test: emulator test and added test coverage
Change-Id: I0c084774a838c0c0b9f3b516011ff31679ae770b
Reviewed-on: https://chromium-review.googlesource.com/914981
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536285}
Reviewed-on: https://chromium-review.googlesource.com/927357
Reviewed-by: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/branch-heads/3325@{#517}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[Merge to M65]ozone: evdev: Partially revert "ozone: evdev: Fix some minor issues and nits"
TBR=minch@chromium.org
Since 8a14e9091d96 we dispatch device change notifications when palm suppression
state changes. This is causing context menus to be dismissed erroneously on stylus
lift. It's unclear why this is happening and should be fixed, but for now just
revert to the old behavior.
This is a partial revert of 8a14e9091d96.
Bug: 810599
(cherry picked from commit f30697974420401bfe6a9205b11b93039f838a36)
Change-Id: Ida6b01f225e35cc7e04b603055a69a25c3f0163d
Reviewed-on: https://chromium-review.googlesource.com/923214
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#537452}
Reviewed-on: https://chromium-review.googlesource.com/927354
Reviewed-by: min c <minch@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#516}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.87
TBR=dimu@chromium.org
Change-Id: I8c1e1a15a19f80989ba8b4babec85f8163455e70
Reviewed-on: https://chromium-review.googlesource.com/927464
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#515}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Merge - [Web Payments] Use OriginalProfile for IdentityProvider in PR
Original commit:
commit e4e004ca8b2eb2ca9fe96ba2916951b6f5af05d4
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Tue Feb 20 18:33:22 2018
[Web Payments] Use OriginalProfile for IdentityProvider in PR
This CL fixes a crash in Incognito where the Payment Request
IdentityProvider attempted to register an Observer on a null
SigninManager. It also brings Payment Request in line with Autofill,
where previously PR was displaying the Original Profile's Autofill data
but wasn't able to unlock cards because the IdentityProvider was invalid
in Incognito.
Bug: 813275
Change-Id: I3fb43ba45404f8884a300d77fda7f8fe0f8364af
Reviewed-on: https://chromium-review.googlesource.com/926563
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#537826}
Reviewed-on: https://chromium-review.googlesource.com/927226
Cr-Commit-Position: refs/branch-heads/3325@{#514}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[CrOS Tether] Filter BLE discovery to LE devices only.
Instant Tethering only uses BLE connections. This filter was not
previously used due to a potential workaround which had been resolved
(see https://crbug.com/759090).
TBR=khorimoto@google.com
(cherry picked from commit a29a5d737d9d8a2aa4c1241c01d7157bb61d3ec2)
Bug: 759091, 672263
Change-Id: I161efd638f683d21596e445a5f1db2f90a838e75
Reviewed-on: https://chromium-review.googlesource.com/919426
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#537140}
Reviewed-on: https://chromium-review.googlesource.com/927342
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#513}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Updating XTBs based on .GRDs from branch 3325
R=cmasso@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ieaf5737223f0f7db9f1b6073f181bdd8510fbed1
Reviewed-on: https://chromium-review.googlesource.com/927203
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#512}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Fix task creation check in ArcKioskAppService.
OnTaskCreated()'s intent parameter has slightly more information
than in AppInfo.
Due to that check existence, task_id_ was never remembered and
the kiosk app was not restarted on crash/termination.
This change won't negatively affect ARC Kiosk functionality as starting
by an intent is not supported anyway.
BUG=812594
BUG=811398
Test=Manual, check that app is properly restarted after termination.
Change-Id: I51523545833744aebc1f1c7dfe9c7aacf7414484
Reviewed-on: https://chromium-review.googlesource.com/922101
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#537056}(cherry picked from commit 00348304f519c4e971cba761b67e23b900c311d6)
Reviewed-on: https://chromium-review.googlesource.com/927241
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#511}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
FileWriterDelegate: Don't flush while async write in progress
If the URLRequestJob signals a read error while an async write is
in progress, don't attempt to flush the FileStreamWriter as that
violates its API. Read/write errors are now routed to separate
handlers, and no flush is attempted after a write error.
Bug: 795881, 732321
Change-Id: I3585b1543df893ac98e9e392e068cf54bd3f0222
Reviewed-on: https://chromium-review.googlesource.com/914933
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536818}(cherry picked from commit ae928080907bb80b25388e2da1591196361674cf)
Reviewed-on: https://chromium-review.googlesource.com/926883
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#510}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Truncate the length of downloaded file name on windows
During annotation, an extra 16 characters(zone identifier)
are appended to the file name.
That may cause the file path to exceed the 260 character limit.
This CL fixes that problem by truncating the file name when generating
it.
BUG=809759
TBR=qinmin@chromium.org
(cherry picked from commit c575e74530267932837e074fa4cdb3df4069d497)
Change-Id: Ie0baa318ccf5824e3ed4df8cf23386653b6747d7
Reviewed-on: https://chromium-review.googlesource.com/919445
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#537093}
Reviewed-on: https://chromium-review.googlesource.com/927041
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#509}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Android: Don't convert star_gray.png to webp.
Decoding crashes on Samsung Galaxy S5 devices running L (potentially
due bugs in the system libs).
TBR=estevenson@chromium.org
(cherry picked from commit b4fba48704688b50928d368e0d54475818d6f889)
Bug: 807059
Change-Id: Iab24378247c3f8c460d54a6515d75f0e1396999c
Reviewed-on: https://chromium-review.googlesource.com/919319
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#537216}
Reviewed-on: https://chromium-review.googlesource.com/926966
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#508}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[scheduler] Fix crash involving fences and non-nestable tasks.
When a non-nestable task is posted inside a nested message loop and a
queue blocked by fence subsequently that means that a blocked queue
will have work posted before inserting a fence and will become unblocked.
Check for this case to correctly notify WorkQueueSets about this
situation (OnTaskPushedToEmptyQueue instead of OnFrontTaskChanged).
R=alexclarke@chromium.org
TBR=altimin@chromium.org
BUG=807297
(cherry picked from commit e803632e9b6c578015ef112babf8c3fc515d527b)
Change-Id: I66acf84003da655771b4f7a44f77b519ce72170b
Reviewed-on: https://chromium-review.googlesource.com/895587
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#533642}
Reviewed-on: https://chromium-review.googlesource.com/926941
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#507}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Disable debugging exception for release
Turn off the IllegalStateException that gets thrown and return early.
This doesn't harm anything, but just makes it harder to track down the
cause. Will reinstitute logging in the near future.
BUG=786916
Change-Id: I761a588121ad032555e44eafae083dcff469558c
Reviewed-on: https://chromium-review.googlesource.com/920044
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#537079}(cherry picked from commit 4b2b4e104fd15f2e90063e3ba7589e9d46472227)
Reviewed-on: https://chromium-review.googlesource.com/926881
Cr-Commit-Position: refs/branch-heads/3325@{#506}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Upgrade rtanaltyics light component to version 2.0.
BUG=810777
Change-Id: I73e61af1152dc31d4087f7225cd10d161ce9db36
Reviewed-on: https://chromium-review.googlesource.com/911832
Commit-Queue: Wei Guan <weigua@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#535833}(cherry picked from commit 5173ffefa24da64919aaebee44ac56dc1ba3b7c2)
Reviewed-on: https://chromium-review.googlesource.com/926761
Reviewed-by: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#505}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Fixes a bug were UKM metrics were not being logged for autofill on iOS
autofill::AutofillManager passes FormData.main_frame_origin to the
autofill::AutofillMetrics::FormInteractionsUkmLogger. This property was not
being set in autofill_agent.mm, therefore no metrics were being logged.
Bug: 812070
Change-Id: I1e337ae6af575fc6182e5b360e44f12427d3d5be
Reviewed-on: https://chromium-review.googlesource.com/917534
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536678}(cherry picked from commit 80f0c5570649c35a869429b2ab8c381a0a7246cb)
Reviewed-on: https://chromium-review.googlesource.com/926821
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#504}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.86
TBR=dimu@chromium.org
Change-Id: I91018f02cd2eed7406a1a49fce5283ef2a1c70f9
Reviewed-on: https://chromium-review.googlesource.com/925643
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#503}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.85
TBR=dimu@chromium.org
Change-Id: Ic760895d6e3227c52d71e3d9c2fffc607ff0bec1
Reviewed-on: https://chromium-review.googlesource.com/925804
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#502}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
|Merge to M65| [Password Manager] Check that |render_frame()| is not null in PasswordAutofillAgent
|render_frame()| may be null. So, |PasswordAutofillAgent::GetPasswordFormFromUnownedInputElements| may crash. See the bug for details.
Bug: 808366
Change-Id: If1e53e5bd11305cdafba165aff755d6f6f88075c
Reviewed-on: https://chromium-review.googlesource.com/921122
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536991}(cherry picked from commit 1e44004d3dfa41d5fa66061e4b1adec285c9f682)
Reviewed-on: https://chromium-review.googlesource.com/925581
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#501}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Surface synchronization: Throttle auto-resize renderer side
This is a short term fix until child-allocated LocalSurfaceIDs are implemented
for auto-resize.
Prior to surface synchronization, child renderers would allocate LocalSurfaceIds
for auto-resize. When the renderer receives a DidReceiveCompositorFrameAck
message then it knows the compositor has received the frame, and informs the
browser process which then resizes the associated aura window to match the
frame generated by the child. This ensured that the aura window would only be
resized to a size that had a surface.
With surface synchronization, every auto-resize resulted in a request for a
LocalSurfaceId from the parent. The parent would immediately resize the aura
window and embed the newly allocated LocalSurfaceId and then tell the child
about it. In the meantime, the child may auto-resize again. Surface
synchronization would block the parent on that LocalSurfaceId
that never resolves until the child makes another request. After the deadline
passes, the user sees flicker.
This CL does not address the root cause of the problem (allocating IDs for
surfaces that are never created), but it does significantly reduce the problem.
Instead of immediately informing the browser when an auto-resize happens in the
renderer. The ACK is posted as a task on the renderer's queue. The renderer may
auto-resize multiple times until that task is handled, and so we effectively
coalesce resize requests before making a request to the browser.
This significantly reduces flicker.
This is not the final state of auto-resize, though. In the future, the renderer
will immediately allocate a LocalSurfaceId and submit a CompositorFrame, and
then tell the browser about it to embed it. Occasionally, there will be a
conflict between browser and renderer changes, but this should be very rare.
TBR=fsamuel@chromium.org
(cherry picked from commit 1ee6fb5c206f8f63176196bfc31aa40721b734c7)
Bug: 812127, 811181, 672962
Change-Id: I08839c4b498b68ba06bb5d818337738e191cf9be
Reviewed-on: https://chromium-review.googlesource.com/920341
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#537173}
Reviewed-on: https://chromium-review.googlesource.com/925542
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#500}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.84
TBR=dimu@chromium.org
Change-Id: I9a14b66ce473285d040a9993405dcc2b5cbb55b0
Reviewed-on: https://chromium-review.googlesource.com/925163
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#499}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.83
TBR=dimu@chromium.org
Change-Id: I549320ec64e5520c73bc4052356ca57c30ba408f
Reviewed-on: https://chromium-review.googlesource.com/925003
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#498}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.82
TBR=dimu@chromium.org
Change-Id: I3c2b75cbe7c2795efd9b6f090311c2cdbb25e5e5
Reviewed-on: https://chromium-review.googlesource.com/923844
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#497}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.81
TBR=dimu@chromium.org
Change-Id: Ifbbbe8241b46682b2616e4146d61b4b2cb4a802f
Reviewed-on: https://chromium-review.googlesource.com/923534
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#496}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.80
TBR=dimu@chromium.org
Change-Id: Iff719a797a1fb5a0532d1f596f4c2099c002d86a
Reviewed-on: https://chromium-review.googlesource.com/924355
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#495}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.79
TBR=dimu@chromium.org
Change-Id: I6269afe479131d956a7ec819bed6dbe5aef7ee77
Reviewed-on: https://chromium-review.googlesource.com/924725
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#494}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[iOS] Mitigate white screen while uploading crash reports.
Between when the root view controller is created and the new (or active)
tab is displayed, there is a brief interval when the root view controller
is displayed. This is usually less than one display refresh cycle, but
if (for example) a crash is being uploaded on a slow device, it may
be longer than that. If so, a white screen will appear (this is the root
view controller's view when it doesn't contain a tab switcher).
To mitigate this effect, this CL has the main view controller add a copy
of the launch screen view to its view hierarchy. It is removed as soon as
another view controller is added as a child of the main view controller.
This is the same approach that's used to solve a similar issue when showing
the FRE on some devices. It's terrible and we will find something better
soon, but this will resolve the issue for M65.
TBR=marq@google.com
(cherry picked from commit 3fb3face370c1039e96da2fdec80869e314eadf0)
Bug: 803758
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ife105aa253019b41eac5002a33e69da71eb51944
Reviewed-on: https://chromium-review.googlesource.com/920521
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#537438}
Reviewed-on: https://chromium-review.googlesource.com/924637
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#493}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[ios] Fix crash in tab switcher
Crash is caused by the previousPanelIndex being out-of-bounds into the
panels array. This CL ensures that previousPanelIndex is kept up-to-date
when any panels are removed so that it is not out-of-bounds.
Bug: 805530
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id193a85585510c50e9bb92680f0782fee7e34d1a
Reviewed-on: https://chromium-review.googlesource.com/916943
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536745}(cherry picked from commit e7bb4fe5c02bf9b51c465d03c7b8ed374b7200ab)
Reviewed-on: https://chromium-review.googlesource.com/923375
Cr-Commit-Position: refs/branch-heads/3325@{#492}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Focusing or hovering over a link in an OOPIF should show a status bubble
TBR=lukasza@chromium.org
(cherry picked from commit fd707147cc193f8ea99c7258e2f2e71b857d3fb1)
Bug: 807776
Change-Id: I6219d7a8bc5a4b2fb608dfde1d0859739a35949f
Reviewed-on: https://chromium-review.googlesource.com/898434
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#535104}
Reviewed-on: https://chromium-review.googlesource.com/924322
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#491}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Workaround for missing didReceiveServerRedirectForProvisionalNavigation
Branch has diverged from the trunk. Trunk fix: crrev.com/c/919664
Bug: 810911
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I07751b8f28a3f2a93ad8ff53aeeb4f97b25075f9
Reviewed-on: https://chromium-review.googlesource.com/923003
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#490}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Android PhotoPicker: Fix crash.
Earlier I fixed a crash in updateSelectionState by
returning early. That, however, isn't enough because
onSelectionState also calls isPictureTile, when it
is not safe to do so (because initialize hasn't been
called).
A better way is to move the early return up one
function in the callstack (from updateSelectionState
to onSelectionState), which should catch both of these
issues.
To be sure, I also checked if updateSelectionState could
be called outside of onSelectionState and found two variants:
1) It is called after initialize (when it is safe).
2) It is called after we call isPictureTile (e.g. in setChecked),
in which case we would already be seeing crash stacks for
that (but we're not).
Bug: 760785, 656015
Change-Id: I0f200b16cd34698e103dc4c2b07b3f86c948adad
Reviewed-on: https://chromium-review.googlesource.com/892886
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#532887}(cherry picked from commit 9e6c6aa91ade7d1b891f2edfd9f6b3d7d123cd2d)
Reviewed-on: https://chromium-review.googlesource.com/924060
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#489}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[Merge to M-65] Fix Chrome IOS Crash
CL https://chromium-review.googlesource.com/c/chromium/src/+/823238/ introduces
processing messages from IFrames. Function CRWWebController:respondToMessage:
userIsInteracting:originURL:isMainFrame: incorrectly processes case when no handler
for message form IFrames. Which leads to using |handler|, when |handler| = nil.
This CL fixes that.
TBR=dvadym@chromium.org
(cherry picked from commit 226e3d9e2242c82571ee6f5a7c1a0319cf1a90af)
Bug: 801485
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I661754b83e2e09a4a907634d15f50e62a315c343
Reviewed-on: https://chromium-review.googlesource.com/916604
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536741}
Reviewed-on: https://chromium-review.googlesource.com/923730
Cr-Commit-Position: refs/branch-heads/3325@{#488}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Hide RequestInit.keepalive in the experimental flag
The logic is unintentionally exposed and this CL fixes that.
TBR=yhirano@chromium.org
(cherry picked from commit f0a1eb5210da96ec6bd94022f36518832e673177)
Bug: 810466
Change-Id: I46091b1ee1fb787195ca9feb7be939df1c5bc258
Reviewed-on: https://chromium-review.googlesource.com/917361
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536649}
Reviewed-on: https://chromium-review.googlesource.com/923504
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#487}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.78
TBR=dimu@chromium.org
Change-Id: I4bbb4ccd2e9a3fafd3d39e8176f911b3a6e13fda
Reviewed-on: https://chromium-review.googlesource.com/923321
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#486}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
M65: Change FontCacheWin::PreCacheFont() to be synchronous.
It was incorrectly changed to be asynchronous in r519471. This causes
the font pre-cache mechanism to become unreliable, as there is no longer
a guarantee that the pre-caching will occur before the font is used.
BUG=809888
TBR=thestig@chromium.org
(cherry picked from commit c80f34c6c7a65103533f4d402917d27d8abba368)
Change-Id: I15d14200c241089ae7d365a6ed0a61b119214e43
Reviewed-on: https://chromium-review.googlesource.com/914511
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536457}
Reviewed-on: https://chromium-review.googlesource.com/923091
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#485}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
DevTools: Fix autocomplete in watch sidebar
Bug: 805837
Change-Id: Ib24d46b9ed98b1264c0ff009ac40846ce254c44f
Reviewed-on: https://chromium-review.googlesource.com/887640
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#533205}(cherry picked from commit 60d90d459261055fff4a1650b6d894b83bb43aa4)
Reviewed-on: https://chromium-review.googlesource.com/923061
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#484}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
cc/ipc: Don't fail filter serialization on insufficent buffer.
When serializing a filter on a CompositorFrame, we would fail if the
total size exceeds 8K. Instead compute the size required before
serializing the filter.
Note that there are cases where the PaintOpWriter can not trivially
compute the exact size required, with complex types like PaintRecords.
But those should never be serialized with security constraints imposed
on PaintFilters serialized with CompositorFrames.
R=enne@chromium.org
TBR=khushalsagar@chromium.org
(cherry picked from commit 252af33418128e61b71b9afe20eba98ad5ed6a5c)
Bug: 810214
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I2733e3fc36a0b5d8076cb064e5f8de1fc14e33b3
Reviewed-on: https://chromium-review.googlesource.com/909960
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536650}
Reviewed-on: https://chromium-review.googlesource.com/922928
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#483}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Add a flag in Settings for UseCounter to avoid measuring shadow pages.
Shadow page has a frame and upon service worker startup, UseCounter will
count page visits.
This CL adds a flag "is_shadow_page_" in Settings and sets the flag to
be true in WorkerPageShadow initialization (by default the flag's value
is false). In UseCounter it checks for shadow pages and drop counts for
shadow pages.
Note that this flag will eventually go away since browser side use
counter does not have problems with workers. So once the blink side
use counter is removed, this change can be undone.
This change has also been verified to work locally.
Bug: 694880
Change-Id: I1cbe857d776591098bbbbf256ef8aa546c399af5
Reviewed-on: https://chromium-review.googlesource.com/917028
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536736}(cherry picked from commit 7890f24a44b6b5bf31243e87900c0192d2373697)
Reviewed-on: https://chromium-review.googlesource.com/922941
Reviewed-by: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#482}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Report First Input Delay across OOPIFs, report First Input Timestamp.
This is a cherry-pick of a reland.
This is a reland of fe64540e01311889d266c94de15b594e3e0f21cc.
Original change's description:
> Report First Input Delay across OOPIFs, report First Input Timestamp.
>
> Previously we only reported for documents in the same process.
>
> Adds InteractiveTiming.FirstInputTimestamp UKM,
> PageLoad.InteractiveTiming.FirstInputTimestamp UMA.
>
> Bug: 803935, 808089
> Change-Id: I182d764257c6ad215c585b938f11a47c88c00b32
> Reviewed-on: https://chromium-review.googlesource.com/901802
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536358}
Accidentally skipped CQ. Then reverted.
TBRing original reviews:
TBR=bmcquade@chromium.org, dtapuska@chromium.org, isherman@chromium.org, tsepez@chromium.org
(cherry picked from commit a10963705bce537dbe00ebdd6f07bde46dda8e3c)
Bug: 803935, 808089
Change-Id: Ia4e47ea1fd4bc557a193b84e199dd9f3ddf1e6cb
Reviewed-on: https://chromium-review.googlesource.com/916007
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536712}
Reviewed-on: https://chromium-review.googlesource.com/922905
Cr-Commit-Position: refs/branch-heads/3325@{#481}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Set up mac v2 sandbox policy for pdf compositor
Pdf compositor service composites contents printed from different
renderer process into a complete pdf document. This is needed for
general printing when site isolation is enabled, because a web page with
out of process iframes may be rendered in multiple renderers.
Therefore, pdf compositor service needs to access font access.
This CL set up pdf compositor service's own seatbelt policy.
BUG=809763, 455764
Change-Id: I4a78ef793c1ea5e52b167a74fd02091f197bd61f
Reviewed-on: https://chromium-review.googlesource.com/912316
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536153}(cherry picked from commit a3533592984bdb788d1335a223b37e125a07c99c)
Reviewed-on: https://chromium-review.googlesource.com/922881
Reviewed-by: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#480}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
📺 Check aspect ratio before attempting PiP.
TBR=peconn@chromium.org
(cherry picked from commit 297583c3ba24caa037cde5209c3a13bdb55126a7)
Bug: 809865
Change-Id: Id630a5f0d7aa7b5ff619b314adffc98868c748d8
Reviewed-on: https://chromium-review.googlesource.com/908557
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#535705}
Reviewed-on: https://chromium-review.googlesource.com/922793
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#479}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
First Input Delay: include swipes, add UKM.
Previously we excluded swiping input. We now include swipes (map panning,
carousel rotation), but still exclude scroll.
Also records a UKM.
Bug: 803935
Change-Id: I8f9d5a77ad61221eb9b614e8d4e11e2b757af9e2
Reviewed-on: https://chromium-review.googlesource.com/894826
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534178}
(cherry picked from commit 827b0b6c5a688b37e330a18a1da1229b16752e18)
TBR=dtapuska@chromium.org, bmcquade@chromium.org
Change-Id: I8f9d5a77ad61221eb9b614e8d4e11e2b757af9e2
Reviewed-on: https://chromium-review.googlesource.com/922790
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#478}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Report First Input Delay via UMA.
Reports the First Input Delay.
PageLoad.InteractiveTiming.FirstInputDelay
Observes:
- MouseDown
- KeyDown, RawKeyDown
- PointerDown (when followed by PointerUp)
- Cancelable TouchStart
- GestureTap
Bug: 803935
Test: WebViewTest.FirstEventQueueingTimeReported, CorePageLoadMetricsObserverTest.FirstEventQueueingTime
Change-Id: I41fddedfe2b0618be0d29d74601df68b04a36210
Reviewed-on: https://chromium-review.googlesource.com/876728
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534136}
(cherry picked from commit bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f)
TBR=dcheng@chromium.org, isherman@chromium.org, kouhei@chromium.org, bmcquade@chromium.org
Change-Id: I41fddedfe2b0618be0d29d74601df68b04a36210
Reviewed-on: https://chromium-review.googlesource.com/922684
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#477}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Merge to M65: Fix critical accessibility bug causing page content to be inaccessible
In Blink accessibility, when an AXObject is "ignored", it's not
included in the accessibility tree. The ignored node's parent
includes the ignored node's children directly, leaving it out of the
tree.
As an example, consider this html:
<html><body><div><button/></div></body></html>
The current heuristics leave the body element out of the accessibility tree.
The accessibility tree looks like:
rootWebArea (the html node)
genericContainer (the div)
button
There are many ways for a node that's ignored to become unignored,
like adding an id or an ARIA attribute. Typically this fires the right
notifications and the node gets spliced into the accessibility tree.
The bug in this case is that adding a click listener to an ignored node
causes it to be not ignored anymore, but it does not correctly invalidate
its parent. In the example above, adding a click listener to the body and
then modifying the html element "breaks" the tree. The HTML node thinks
its child is the DIV, but the DIV thinks its parent is the BODY. This
inconsistency breaks the entire page's accessibility tree.
The fix is to catch changes to a node's ignored state and call ChildrenChanged.
Bug: 797695
Change-Id: Ib8b077e3ebb96ec1634a847db7477589cde74012
Reviewed-on: https://chromium-review.googlesource.com/910123
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#535734}(cherry picked from commit 7dc3a173d256cf3edbca00d8ca2680a4e4b32a97)
TBR: nektar@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/922561
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#476}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[iOS][Signin] Fixing font issues on the MDCButton
With a MDCButton, the font should not be set on the title label, but on the
button itself, using:
-[MDCButton setTitleFont:forState:]
Bug: 803767
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4232f2d080daca4e8fc2e585d51c24c1b10ab1ac
Reviewed-on: https://chromium-review.googlesource.com/891221
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#533067}(cherry picked from commit b17acb28d6bb401d444032da809e154e75b3b1e0)
Reviewed-on: https://chromium-review.googlesource.com/921541
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#475}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Changed QuotaManager to be refcounted in QuotaDispatcherHost
Bug: 800349
Change-Id: I4555b66e001907803ec47597cdc2111cc62807bd
Reviewed-on: https://chromium-review.googlesource.com/895230
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#533892}(cherry picked from commit e2db7866bc3634b8515c44df45986cd82932f99e)
Reviewed-on: https://chromium-review.googlesource.com/920962
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#474}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.77
TBR=dimu@chromium.org
Change-Id: Icd9ba2352b7586fb5cf5bae6ce3ffde432c30388
Reviewed-on: https://chromium-review.googlesource.com/920704
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#473}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.76
TBR=dimu@chromium.org
Change-Id: Ie3a1a9deebdfc91ac5b93815f4075bb849015d7c
Reviewed-on: https://chromium-review.googlesource.com/920404
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#472}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Regenerate gpu/config testing data for content_unittests.
Still building this locally to confirm the fix, but 99% sure this will
fix the build problem on the bots.
Ran src/gpu/config/process_json.py to generate this.
TBR=zmo@chromium.org
Bug: 812373
Change-Id: I715fb069b4b41d6c24559cbab3cad795325d40fe
Reviewed-on: https://chromium-review.googlesource.com/920103
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#471}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Remove event coalescing from RenderWidgetTargeter.
The code removed in this CL is believed to be the root cause of the
crash in the associated bug.
The mechanism is this: when events are coalesced, some event types still
expect all of the original events to be properly acked, and at present
RenderWidgetTargeter doesn't implement this. The crash, in particular,
is the result of touch events being acked in a way that the unique ids
don't line up with the queue in
TouchDispositionGestureFilter::OnTouchEventAck()
because some of the ids are missing after being coalesced.
At present we will only disable coalescing for touch and gesture
events,but that's reasonable since in most cases we only everhit-test
the initial TouchStart and everything else in the sequence latches to
its target.
Further, it's not obvious if there's a significant performance
benefit to the coalescing these events, so for now we remove it.
In any case, implementing proper acking of these events would result
in a patch too big to merge back to M65.
TBR=wjmaclean@chromium.org
(cherry picked from commit 29de174eb52e75a7606f00b6fe3124a953b6d8c5)
Bug: 807507
Change-Id: I7bc45596d5a403118fd3905950fc777a8e4bfa1f
Reviewed-on: https://chromium-review.googlesource.com/913549
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536082}
Reviewed-on: https://chromium-review.googlesource.com/919964
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#470}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Turn off "shader var init in a loop" on Mac Intel to avoid perf regression.
BUG=809422
TEST=manual
R=kbr@chromium.org, oetuaho@nvidia.com
TBR=zmo@chromium.org
(cherry picked from commit 04dc3fe0ebce31ddfe0249be05e7658177235605)
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I665ae361cc9485c120ca2fdb5d174213e083042b
Reviewed-on: https://chromium-review.googlesource.com/917018
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536514}
Reviewed-on: https://chromium-review.googlesource.com/919424
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#469}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
VR: Fix 2D UI flash on headset insertion entering VR.
Setting the window mode too early leads to it racily being ignored by
the platform, and the 150ms we allowed for window animations wasn't
enough in some cases, especially in debug builds.
TBR=mthiesse@chromium.org
(cherry picked from commit 7363cdb51f222c9a9afc1f3004d412c371736486)
Bug: 810039
Change-Id: I73873ce5ee99ea0ab21cfeb4d53f89b7bd97f979
Reviewed-on: https://chromium-review.googlesource.com/908719
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#535425}
Reviewed-on: https://chromium-review.googlesource.com/919317
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#468}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Return the FrameSinkId of |widget_| if remote frame's is not valid yet.
RenderFrameProxy::frame_sink_id_ is set in OnViewChanged(), so it might
not be ready yet when blink does hit-testing. In that case, changes it
to return the FrameSinkId for the current |widget_| instead.
Bug: 810350
Change-Id: I26ed78126701d8155311b8e2872ccac2cea3701e
Reviewed-on: https://chromium-review.googlesource.com/911936
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#535812}(cherry picked from commit 195db4ec8d8bc4fc650015fdd86de98ce81748d1)
Reviewed-on: https://chromium-review.googlesource.com/919801
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#467}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Print Preview: Prevent crash due to printing and cancellation (M65)
Bug: 811192
Change-Id: I214a083b729fbec0fde900196132d3a1b4b420c4
Reviewed-on: https://chromium-review.googlesource.com/916713
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536620}(cherry picked from commit 3b9cfdda2eb80dab7457ec61e619dd910d194248)
TBR: thestig@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/919486
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#466}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Print Preview: Fix Mac Open in Preview bug (M65)
If the user starts a print job by clicking open pdf in preview, it
should be handled as a print to a local printer even if the currently
selected printer is a cloud printer.
Bug: 811662
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I92d97843816d375cf02c807356e837cd0cf33f7c
Reviewed-on: https://chromium-review.googlesource.com/916721
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536614}(cherry picked from commit a99415dbc7a7c13a94905f103324f747f8a2fc0b)
TBR: thestig@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/919042
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#465}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Change sync objects to not be available in the current frame.
(Manual M65 merge-back)
Follows similar restrictions for query objects and implements
https://github.com/KhronosGroup/WebGL/pull/2598 .
Disable EXT_disjoint_timer_query at the WebGL level.
TBR=dcheng@chromium.org, kainino@chromium.org, piman@chromium.org, zmo@chromium.org
Bug: 808744
Change-Id: Ibf27298392cabb87fa0222e18145682a55392997
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/919154
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#464}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Avoid event routing for View pending deletion
Crash reports suggest that RenderWidgetTargeter::FoundTarget() is being
called with a valid (non-null) target but that target has no
RenderWidgetHostImpl, suggesting Destroy() has been called. This is
likely because RenderWidgetHostViewMac can be destroyed asynchronously
and a hit test query reponse is getting in that window.
This CL adds a check for that case.
Bug: 809378
Change-Id: Ice855a3b2f12b8db6092a6aa15c595b29aae750e
Reviewed-on: https://chromium-review.googlesource.com/912030
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536108}(cherry picked from commit ca980c4123704d37c1a32d931cf962489b9bc1e0)
Reviewed-on: https://chromium-review.googlesource.com/919341
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#463}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Refresh Public Suffix List to the latest version.
This updates from revision
fe6b36209b2cee5740d8909e3f1c9624756a628a (2017-08-21)
to revision
0f3b07d9aab6d6c9fe74990af98316468d40f488 (2018-01-25)
TBR=martijn@martijnc.be
(cherry picked from commit db2608b46afa5baa7ec26f16e97700e3b614e18f)
Bug: 798114
Change-Id: Ic2b68b8f5541d43867ce18bfc7c055df92d64833
Reviewed-on: https://chromium-review.googlesource.com/846806
Commit-Queue: Martijn Croonen <martijnc@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536439}
Reviewed-on: https://chromium-review.googlesource.com/919068
Cr-Commit-Position: refs/branch-heads/3325@{#462}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Avoid saving passwords when the user is signing in to Chrome.
When Desktop Identity Consistency is enabled, the Chrome sign-in flow uses
a specific Gaia web page (accounts.google.com/chrome/sync). It also passes the URL parameter
"ssp=1" that is passed to all sign-in URLs to which the navigates during the Chrome
signn flow.
This CL avoids presenting the save passwords bubble for Gaia URLs used if the Gaia URL
has the "ssp=1" URL parameter.
TBR=msarda@chromium.org
(cherry picked from commit a66266e75c7ffaf9dcfd572fed4fb6db3029fa44)
Bug: 805826
Change-Id: I7511961a0da103a51ebf022344a24383183c18b4
Reviewed-on: https://chromium-review.googlesource.com/888623
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536089}
Reviewed-on: https://chromium-review.googlesource.com/918864
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#461}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.75
TBR=dimu@chromium.org
Change-Id: I29d1ce0052ba468a4c57fb59139daac6dd7cbebf
Reviewed-on: https://chromium-review.googlesource.com/917941
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#460}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Add icon to OOBE advanced options dialog
Also, makes "Welcome!" text in welcome dialog not selectable.
BUG=797021, 805492
TBR=tbarzic@google.com
(cherry picked from commit 2b3970a2d688a88ab06dd8967acfd7eb90c6a28b)
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id8ac18d8a49c923fb0bd79a5f081c963ab4c0ae7
Reviewed-on: https://chromium-review.googlesource.com/907728
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#535236}
Reviewed-on: https://chromium-review.googlesource.com/917539
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#459}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
Incrementing VERSION to 65.0.3325.74
TBR=dimu@chromium.org
Change-Id: I781b319fb2503940cdc27522cf7f19e1df0436b9
Reviewed-on: https://chromium-review.googlesource.com/917482
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#458}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}