Publish DEPS for Chromium 42.0.2311.22
Incrementing VERSION to 42.0.2311.22
Cr-Commit-Position: refs/branch-heads/2311@{#142}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
ozone: evdev: Sync caps lock LED state to evdev
Update LED state in kernel in InputControllerEvdev::SetCapsLockEnabled.
This is currently the only way to toggle caps lock.
BUG=463242
TEST=plug in external keyboard on link_freon & press caps lock. Light on
keyboard should turn on.
Review URL: https://codereview.chromium.org/971753006
Cr-Commit-Position: refs/heads/master@{#318934}
(cherry picked from commit fc0faf53d30d331094b79fc77339184854169421)
Review URL: https://codereview.chromium.org/982593004
Cr-Commit-Position: refs/branch-heads/2311@{#141}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Incrementing VERSION to 42.0.2311.21
Cr-Commit-Position: refs/branch-heads/2311@{#140}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Remove HRD butterbar and disable HRD background service
BUG=462072
Review URL: https://codereview.chromium.org/964723003
Cr-Commit-Position: refs/heads/master@{#318921}
(cherry picked from commit bad02d28065cbabb8d79a0804343cd2af93a7a37)
TBR=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/976083004
Cr-Commit-Position: refs/branch-heads/2311@{#139}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Add support for direct download of the SRT.
Fallsback to the DL page if necessary.
BUG=440407
Review URL: https://codereview.chromium.org/926983002
(cherry picked from commit 526f4a51d0746ed91d98fd10b9c34a29136554fa)
Cr-Original-Commit-Position: refs/heads/master@{#317954}
Cr-Commit-Position: refs/branch-heads/2311@{#138}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Show AboutChromePreferences "updates no longer supported" warning
Display the "updates no longer supported" warning for devices
< JELLY_BEAN on the About Chrome settings page.
BUG=438861
Committed: https://crrev.com/9a920de9d96d789023d807ee40f91509f5e8bab6
Cr-Commit-Position: refs/heads/master@{#318967}
R=newt@chromium.org
Review URL: https://codereview.chromium.org/964873004
Cr-Commit-Position: refs/branch-heads/2311@{#137}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Exit HTML Fullscreen when browser fullscreen is active.
Ensure web contents exit fullscreen state by sending a resize message, which includes the fullscreen state. This is required for the situation of the browser moving the view into a fullscreen state "browser fullscreen" and then the contents entering "tab fullscreen". Exiting the contents "tab fullscreen" then won't have the side effect of the view resizing, hence the explicit call here is required.
Fixes a regression caused in the refactoring
Fullscreen: make fullscreen requests come from RenderFrame
https://codereview.chromium.org/789533002
https://crrev.com/7a78d6fd7dc3241a91a614a09f9c59a0e4454135
where the previous implementation's call to WasResized in
RenderViewHostImpl::OnToggleFullscreen was not brought forward to
WebContentsImpl::ExitFullscreenMode().
BUG=458013
TEST=Open http://scheib.github.io/HTMLMisc/PointerLockAndFullscreen.html, enter Browser Fullscreen with F11 key, press Toggle Fullscreen button, press ESC key, expect content to exit fullscreen.
Review URL: https://codereview.chromium.org/928673002
(cherry picked from commit 3dcb6c931a974f4e825f5383e98ed5b958819b56)
Cr-Original-Commit-Position: refs/heads/master@{#317562}
Cr-Commit-Position: refs/branch-heads/2311@{#136}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
QUIC - Add a field trial not to load QUIC server information from the
disk cache.
TBR=rch@chromium.org
Review URL: https://codereview.chromium.org/948143004
Cr-Commit-Position: refs/heads/master@{#317916}
(cherry picked from commit 34dffe756274e6ddf7c8b6b0d2edbebe69c837f7)
BUG=463992
Review URL: https://codereview.chromium.org/982563005
Cr-Commit-Position: refs/branch-heads/2311@{#135}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Incrementing VERSION to 42.0.2311.20
Cr-Commit-Position: refs/branch-heads/2311@{#134}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Disable VideoDecoder renderer in M42 chrome.
There are some issues with the VideoDecoder renderer in M42 chrome,
particularly on ARM. Don't use it there.
BUG=459103,463577
Review URL: https://codereview.chromium.org/967733006
Cr-Commit-Position: refs/heads/master@{#318966}
(cherry picked from commit 5b546a437eabff7aaa420ad3f17bbd6397dc3666)
TBR=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/979733003
Cr-Commit-Position: refs/branch-heads/2311@{#133}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Cherry pick HarfBuzz reverse_range fix
Cherry pick the HarfBuzz commit 8ac345e5c0ed0aad6547592ea0839aabfb4ba980
as it fixes a set of serious shaping regressions in the core text shaper
on Mac OS. Cherry picking as opposed to rolling to allow for a clean DI.
BUG=459043
TBR=behdad@chromium.org
Review URL: https://codereview.chromium.org/971153002
Cr-Commit-Position: refs/heads/master@{#318901}
(cherry picked from commit 36504aa38b58939d103253524f2b9620ce998507)
Review URL: https://codereview.chromium.org/983433003
Cr-Commit-Position: refs/branch-heads/2311@{#132}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Revert "[Android] Fix a flicker in stopping Chrome"
This reverts commit e4b1990c9d49fd9734940fa863513ad43b82c6e7.
BUG=434401
Review URL: https://codereview.chromium.org/969533003
Cr-Commit-Position: refs/branch-heads/2311@{#131}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
[Android] Cache function templates in GinJavaBridgeObject to avoid memory leak
V8 caches all function templates internally for the lifetime of a web page in an
unbounded cache. Thus, creating a new function template for each call to a
method of injected object caused JS heap memory to grow linearly.
This is similar to a fix for Pepper Plugin objects (https://codereview.chromium.org/785213002/)
BUG=462664
Review URL: https://codereview.chromium.org/969353004
Cr-Commit-Position: refs/heads/master@{#318890}
(cherry picked from commit 8f8de9cf6f95d27dd01b834f2fabcc8389315d37)
Review URL: https://codereview.chromium.org/979843002
Cr-Commit-Position: refs/branch-heads/2311@{#130}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Make combined native/manual JNI registration work for clang.
Since clang has trouble with aliases for static functions, go back to
using a trivial wrapper function instead of an alias. Since there is
only one caller of the wrapped, static function, and its address is no
longer taken to generate the manual JNI registration table (the
wrapper's address is already being taken instead), there's no actual
benefit to using an alias anyway, since the compiler will simply inline
the static function into the wrapper.
BUG=442327,460857
TBR=cjhopman@chromium.org
Review URL: https://codereview.chromium.org/953523003
Cr-Commit-Position: refs/heads/master@{#317787}
(cherry picked from commit cab875835ac9e39183ba0ac4fe30e96d1bdfec45)
Review URL: https://codereview.chromium.org/977043002
Cr-Commit-Position: refs/branch-heads/2311@{#129}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Kiosk mode: SetFirstLoginPrefs() should be called for kiosk sessions.
SetFirstLoginPrefs() should be called for kiosk sessions.
BUG=445544
TEST=manual
TBR=nkostylev@chromium.org
Review URL: https://codereview.chromium.org/954033003
Cr-Commit-Position: refs/heads/master@{#318239}
(cherry picked from commit e66a496041854c832b7de03184fe445ed3314613)
Review URL: https://codereview.chromium.org/968193005
Cr-Commit-Position: refs/branch-heads/2311@{#128}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Don't show request dialog for active permissions.
BUG=456633
TEST=manual
Review URL: https://codereview.chromium.org/952773004
Cr-Commit-Position: refs/heads/master@{#318419}
(cherry picked from commit dee660df002733a4d826b245847cf6a9fb103c1a)
Review URL: https://codereview.chromium.org/979703002
Cr-Commit-Position: refs/branch-heads/2311@{#127}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Fix typo in histogram name.
The CL https://codereview.chromium.org/943823002/ introduced a new
histogram for whether web pages are assumed to be mobile friendly.
However, there was a typo in recording the histogram name.
This fixes the recording part to match the histogram.
BUG=462721
TBR=jdduke@chromium.org
Review URL: https://codereview.chromium.org/965883002
Cr-Commit-Position: refs/heads/master@{#318532}
(cherry picked from commit b2faf29ec6489d144d047191168cee463dd0710e)
Review URL: https://codereview.chromium.org/972153007
Cr-Commit-Position: refs/branch-heads/2311@{#126}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Refactor codes to run only the bitmap converting logic in background
This is to fix regression of https://codereview.chromium.org/913033002.
BUG=455996
Review URL: https://codereview.chromium.org/972293003
TBR=tedchoc@chromium.org
Cr-Commit-Position: refs/heads/master@{#319010}
(cherry picked from commit fb9b01d202733f2ab696c3718fc32fee17d91cf5)
Review URL: https://codereview.chromium.org/974903007
Cr-Commit-Position: refs/branch-heads/2311@{#125}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Correctly handle tab navigation in the app list.
This CL causes the app list tab navigation to correctly cycle to and from
the custom launcher page. This has been fixed by adding a SearchBoxFocusHost
which directs the focus search to the search box.
BUG=462079
Review URL: https://codereview.chromium.org/960133005
Cr-Commit-Position: refs/heads/master@{#318814}
(cherry picked from commit a4e2242b75647b641e6d2190b01cde7c9c5233c8)
TBR=mgiuca@chromium.org
Review URL: https://codereview.chromium.org/981453003
Cr-Commit-Position: refs/branch-heads/2311@{#124}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Fix sort order of unlaunched apps on app list start page.
This CL fixes an issue with the app list start page sort order for
unlaunched apps. Folder items were being weighted too highly, causing
them to appear first. The items that are not in a folder will now
appear first in the recommendations, in app list order.
BUG=455338
Review URL: https://codereview.chromium.org/954363002
Cr-Commit-Position: refs/heads/master@{#318642}
(cherry picked from commit 0f1ee572dcbbd4a283bccafe07ac071092003357)
TBR=mgiuca@chromium.org
Review URL: https://codereview.chromium.org/977823002
Cr-Commit-Position: refs/branch-heads/2311@{#123}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
ServiceWorker: Use scheduler's default task queue for posting tasks on main thread
This fixes a task ordering bug between WebMessagePortChannelImpl and
ServiceWorkerScriptContext. The former posts tasks via the Blink
scheduler's default task queue, and the latter was using the MessageLoop
directly. This patch makes tasks from service worker to the main thread
go through the scheduler.
BUG=460833
TEST=http/tests/serviceworker/postmessage-msgport-to-client.html
Review URL: https://codereview.chromium.org/958523002
Cr-Commit-Position: refs/heads/master@{#318022}
(cherry picked from commit a7fe515e3ca07e260b58ebf460f842601266ed87)
TBR=falken@chromium.org
Review URL: https://codereview.chromium.org/973823004
Cr-Commit-Position: refs/branch-heads/2311@{#122}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Files.app: Introduce check-select mode.
Check-select mode spec is here: https://docs.google.com/document/d/1kCG0AFtZSlxlkuipNHlKLY2nvjPdDCViG6RKhMI5-dc/edit
Mode transition rules:
+ Entering check-select mode
- When two or more items are selected.
- When checkmark area is clicked.
+ Leaving check-select mode
- When all items are unselected.
- When non-checkmark area on an item is clicked.
- When direction key(UP,LEFT,etc...) results in single selection.
BUG=460220
TEST=manually tested
TBR=hirono@chromium.org
Review URL: https://codereview.chromium.org/962103002
Cr-Commit-Position: refs/heads/master@{#318658}
(cherry picked from commit e144d30232209034b82d544926070bb8dc62f6ec)
Review URL: https://codereview.chromium.org/979433003
Cr-Commit-Position: refs/branch-heads/2311@{#121}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Leave ImportantFileWriter::WriteFileAtomically argument info in the stack
Leave some info in the stack so that it gets included in the crash reports.
BUG=418627
Review URL: https://codereview.chromium.org/963443002
Cr-Commit-Position: refs/heads/master@{#318398}
(cherry picked from commit e2df4a5855965e022f2899bde122b4b46ce230fd)
BUG=462487
TBR=hashimoto@chromium.org
Review URL: https://codereview.chromium.org/977813002
Cr-Commit-Position: refs/branch-heads/2311@{#120}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Incrementing VERSION to 42.0.2311.19
Cr-Commit-Position: refs/branch-heads/2311@{#119}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Use own GLHelper for surfaceless, the default one is on a different context
BUG=461401
TBR=danakj
Review URL: https://codereview.chromium.org/959463002
Cr-Commit-Position: refs/heads/master@{#317912}
(cherry picked from commit 87d563ec44a9657a0c77b5d2a8ad1cc85376cac4)
Review URL: https://codereview.chromium.org/972313003
Cr-Commit-Position: refs/branch-heads/2311@{#118}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Make sure content offset gets updated
On Webapp, touch gestures are offset by the size of the toolbar, even when
the toolbar is hidden. This occurs because we assume that the previous
content offset can never be 0, ending up not calling
onVisibleContentOffsetChanged() callback.
We can fix it by initializing previous content offset as NaN.
BUG=459275
Review URL: https://codereview.chromium.org/970813003
Cr-Commit-Position: refs/heads/master@{#318974}
(cherry picked from commit 19f04a05b39e5586cba79eaba009ae675ca6aad1)
Review URL: https://codereview.chromium.org/973413002
Cr-Commit-Position: refs/branch-heads/2311@{#117}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Merge: Fix aborting in throttled file system (FSP).
The previous logic was causing a memory corruption when aborting was not
invoked with the callback, but due to unmounting the file system.
As there are multiple paths for aborting, this CL adds a method IsAborted on
the Queue class so it's possible to check if a task has been aborted before.
TBR=hirono@chromium.org # For merge.
TEST=unit_tests: *FileSystemProviderQueue*
BUG=454310
Review URL: https://codereview.chromium.org/968763002
Cr-Commit-Position: refs/heads/master@{#318652}
(cherry picked from commit d3126d1fbaec8f9cbf513ac436ae634e2d12b093)
Review URL: https://codereview.chromium.org/975243002
Cr-Commit-Position: refs/branch-heads/2311@{#116}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Incrementing VERSION to 42.0.2311.18
Cr-Commit-Position: refs/branch-heads/2311@{#115}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
[Ozone-Dri] Set DPMS when configuring displays and remove ForceDPMSOn
We're forcing DPMS to on since some drivers may not perform it
themselves. We also want to only do it on displays that are modeset
otherwise we may be putting disabled displays in a higher power
state.
BUG=chrome-os-partner:36664
Review URL: https://codereview.chromium.org/958933003
Cr-Commit-Position: refs/heads/master@{#318490}
(cherry picked from commit 0866c10f7a2cbcd909c354999c9ba5d021c909a1)
Review URL: https://codereview.chromium.org/978663002
Cr-Commit-Position: refs/branch-heads/2311@{#114}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
[GCM] Fixing the problem of passing linked_ptr across threads
This is a merge to 2311 M42
BUG=461936
TBR=zea@chromium.org
Review URL: https://codereview.chromium.org/958133004
Cr-Commit-Position: refs/heads/master@{#318368}
(cherry picked from commit 50b5f9adbfc882750c45eedde5f192e8c930f7f5)
Review URL: https://codereview.chromium.org/979583002
Cr-Commit-Position: refs/branch-heads/2311@{#113}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Add WiMAX to ONC validation list
Currently type WiMAX fails ONC validation so any property
changes from Settings are ignored.
This also fixes the Cellular translation and adds both Cellular and WiMAX to the validation tests.
BUG=460829
TBR=pneubeck@chromium.org
Review URL: https://codereview.chromium.org/949783003
Cr-Commit-Position: refs/heads/master@{#318162}
(cherry picked from commit b1754c5c8b5b939aac67e1e43b71a70c50e64bac)
Review URL: https://codereview.chromium.org/975103002
Cr-Commit-Position: refs/branch-heads/2311@{#112}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Incrementing VERSION to 42.0.2311.17
Cr-Commit-Position: refs/branch-heads/2311@{#111}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Use a stable device-user identifier for CryptAuth enrollments.
This id should not change if the same user is removed and added to the same
device.
BUG=455515
TEST=removed account, added account back and id is still the same
Review URL: https://codereview.chromium.org/877033005
Cr-Commit-Position: refs/heads/master@{#318001}
(cherry picked from commit 7df5c5cf5459cf393fe775a6bf508b801ef19fe1)
TBR=xiyuan@chromium.org, isherman@chromium.org
Review URL: https://codereview.chromium.org/972983004
Cr-Commit-Position: refs/branch-heads/2311@{#110}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Merge M-42: Move device-log UI strings to generated_resources
BUG=462044
Review URL: https://codereview.chromium.org/956623010
Cr-Commit-Position: refs/heads/master@{#318173}
R=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/961203002
Cr-Commit-Position: refs/branch-heads/2311@{#109}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
ChannelMojo should use PID from the bootstrap Channel.
The original naive implementation ignores sandboxing limitation.
It should ask underlying channel to do it correctly.
TEST=IPCChannelMojoTest.VerifyGlobalPid
R=agl@chromium.org, viettrungluu@chromium.org
TBR=agl@chromium.org
BUG=451553
Review URL: https://codereview.chromium.org/942933005
Cr-Commit-Position: refs/heads/master@{#318099}
(cherry picked from commit 0bd20bd071b18f094999263b377ee58173347567)
Review URL: https://codereview.chromium.org/976763002
Cr-Commit-Position: refs/branch-heads/2311@{#108}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
ChannelMojo: Reduce the number of dup() call
Some crash reports suggest that dup() occasionally fails in the wild.
It is used to simplify the code presuming that dup() doesn't fail
there, but apparently that isn't true.
This change skips dup() when the PlatformFileAttachment owns the
file. It helps decreasing the number of dup() calls.
BUG=457869
R=agl@chromium.org, viettrungluu@chromium.org
TBR=agl@chromium.org
Review URL: https://codereview.chromium.org/959533002
Cr-Commit-Position: refs/heads/master@{#317957}
(cherry picked from commit 98ac98f2e5ab1766c9850b5d9a424f47bdf10205)
Review URL: https://codereview.chromium.org/975853002
Cr-Commit-Position: refs/branch-heads/2311@{#107}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
gpu: Avoid detaching images with glTexSubImage2D
Avoid optimization of using glTexImage2D over glTexSubImage2D when there
are EGLImages attached to the texture, as glTexImage2D will orphan the
EGLImage. Orphaning and reattachment is probably more expensive than the
win of using glTexImage2D over glTexSubImage2D.
BUG=460344
Review URL: https://codereview.chromium.org/954053002
Cr-Commit-Position: refs/heads/master@{#318141}
(cherry picked from commit 45dc77a1ea86f69cce11e72bf5782310b5cb084b)
TBR=boliu@chromium.org
Review URL: https://codereview.chromium.org/975843002
Cr-Commit-Position: refs/branch-heads/2311@{#106}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Fix the Fast User Switcher in the Windows Native frame.
BUG=457462
R=anthonyvd@chromium.org
TBR=anthonyvd@chromium.org
TEST=
1. Disable #enable-fast-user-switcher and enable #new-avatar-menu flags in chrome://flags
2. Relaunch Chrome
3. Right click on the Avatar Button, the fast user switcher should be shown
4. Command+Click on the Avatar Button, nothing should happen
5. Test the functionality with and without custom themes active
Review URL: https://codereview.chromium.org/950293003
Cr-Commit-Position: refs/heads/master@{#317917}
(cherry picked from commit dabd39abad0a01181dd6617199b9f2d9e606f065)
Review URL: https://codereview.chromium.org/972233002
Cr-Commit-Position: refs/branch-heads/2311@{#105}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Added isSyncingUrlsWithKeystorePassphrase.
This determines if sync is initialized and syncing URLs with the
appropriate keystore passphrase type to support contextual searches.
BUG=460786
Review URL: https://codereview.chromium.org/946273002
Cr-Commit-Position: refs/heads/master@{#317610}
(cherry picked from commit a68bc5fc4270c417e758a5b5b4e094b1d8b97c1c)
Review URL: https://codereview.chromium.org/976743002
Cr-Commit-Position: refs/branch-heads/2311@{#104}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Merge to M42: Fix a case where AXTreeSerializer didn't handle reparenting.
Additional unit tests that caught this case are forthcoming. This is a
simple and safe patch for merging.
BUG=452607
Review URL: https://codereview.chromium.org/966833002
Cr-Commit-Position: refs/heads/master@{#318660}
(cherry picked from commit 7a6d7e70755232d232916d78ca8ae94a5ca14dea)
Review URL: https://codereview.chromium.org/976733002
Cr-Commit-Position: refs/branch-heads/2311@{#103}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Fix crashes on ICS.
We were using several APIs introduced after API level 14. Fix that.
BUG=462802
R=estade@chromium.org
Review URL: https://codereview.chromium.org/963993002
Cr-Commit-Position: refs/heads/master@{#318731}
(cherry picked from commit bbc424dd379ed9e75f133da50e313e814105a327)
Review URL: https://codereview.chromium.org/967633004
Cr-Commit-Position: refs/branch-heads/2311@{#102}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
[Document mode] Keep tab ID list in sync with Tab entries
It is possible to have one DocumentActivity create a Tab and add its ID to the
DocumentTabModel, but get interrupted (somehow) before the Tab Entry is added
to the DocumentTabModel. This results in getCount() returning the correct number
of Tabs that exist but fail to have any information about the new Tab, resulting
in getTabAt() returning |null|. We should instead keep the ID list and the Entry
list be as in sync as possible, adding the Entry directly to the DocumentTabModel
as soon as we let the DocumentTabModel know about the Tab's existence.
Add new methods to tie the addTabId and updateEntry functions together via addTab,
deprecate the old ones, and assert that we should never get into a bad state.
Deprecated methods will be culled when the downstream patch lands.
BUG=457427
Original commit: https://crrev.com/7710ef5ff57f581f66dbbaad2dffe8c4a9048add
Original review: https://codereview.chromium.org/969443003
TBR=mariakhomenko@chromium.org
Review URL: https://codereview.chromium.org/973123002
Cr-Commit-Position: refs/branch-heads/2311@{#101}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Merge: Fix unit tests on official bots.
Some of the tests weren't properly instantiating a PrefService. It's now being
done in the ExtensionServiceTestBase class and its subclasses were modified
where needed.
BUG=461484
Review URL: https://codereview.chromium.org/965803003
Cr-Commit-Position: refs/heads/master@{#318552}
(cherry picked from commit 404d6107e0215a5c3914b8d3b18f4851e9551a07)
Conflicts:
chrome/browser/extensions/extension_service_test_base.cc
Review URL: https://codereview.chromium.org/978453002
Cr-Commit-Position: refs/branch-heads/2311@{#100}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Fix favicon padding in Site Settings on pre-L devices.
The problem was that the preference layout is quite different between L
and pre-L devices, so adjusting the padding of the icon's parent view
had very different effects in those two cases. Now, we simply set the
padding of the icon view itself to get the favicon where we want it.
BUG=454850
Review URL: https://codereview.chromium.org/956303003
Cr-Commit-Position: refs/heads/master@{#318749}
(cherry picked from commit aa788c1cf0f961541a7806460948eb01f3ea0147)
Review URL: https://codereview.chromium.org/975753003
Cr-Commit-Position: refs/branch-heads/2311@{#99}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Remove one pixel line in the fast user switcher appearance when there are no profiles to display.
BUG=458355
R=anthonyvd@chromium.org
TBR=anthonyvd@chromium.org
TEST=
Make sure the new avatar menu flag is enabled.
1. Open a Chrome instance with 0 or 1 available profiles.
2. Right click on the User Menu button.
3. Nothing should be displayed.
4. Open the User Manager and add some profiles until there are at least 2.
5. Right click on the User Menu button
6. The fast user switcher should display a list of profiles that can be switched to.
Review URL: https://codereview.chromium.org/944563002
Cr-Commit-Position: refs/heads/master@{#318063}
(cherry picked from commit 3803191395efc35ca1dc288e16d47987a2bf4176)
Review URL: https://codereview.chromium.org/978443003
Cr-Commit-Position: refs/branch-heads/2311@{#98}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Bring up fast user switcher on right-click of the avatar menu on Mac.
Change the behavior of fast user switching on Mac from Command click to right
click to be consistent with Windows and Linux.
BUG=458755
R=anthonyvd@chromium.org
TBR=anthonyvd@chromium.org
TEST=
1. Disable #enable-fast-user-switcher and enable #new-avatar-menu flags in chrome://flags
2. Relaunch Chrome
3. Right click on the Avatar Button, the fast user switcher should be shown
4. Command+Click on the Avatar Button, nothing should happen
Review URL: https://codereview.chromium.org/916523003
Cr-Commit-Position: refs/heads/master@{#317631}
(cherry picked from commit 95b89c2672ce7b0ed1a6803b59acee369b232a3c)
Review URL: https://codereview.chromium.org/961993005
Cr-Commit-Position: refs/branch-heads/2311@{#97}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Merge: Only take basename of default_file_name when starting a File Chooser.
Validate no ViewHostMsg_RunFileChooser messages received in the browser contain no path elements.
BUG=444198
TEST=content_browsertests
Review URL: https://codereview.chromium.org/817103002
Cr-Commit-Position: refs/heads/master@{#318111}
(cherry picked from commit 815c487fa677cf5413ed22e181437c1107300d49)
Review URL: https://codereview.chromium.org/977593002
Cr-Commit-Position: refs/branch-heads/2311@{#96}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Settings: Make the manage-profile overlay wider to fit the icons in it.
BUG=460835
TEST=manually check the repro steps on the issue
TBR=dbeam@chromium.org
Review URL: https://codereview.chromium.org/954913003
Cr-Commit-Position: refs/heads/master@{#318513}
(cherry picked from commit dcaf85760480be9dd9a085544d193a3997e1556a)
Review URL: https://codereview.chromium.org/967423004
Cr-Commit-Position: refs/branch-heads/2311@{#95}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Incrementing VERSION to 42.0.2311.16
Cr-Commit-Position: refs/branch-heads/2311@{#94}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Force glFinish for page flips on a UDL device.
This is a temporary workaround. TODO: crbug.com/462360
replace with a per-surface flush as it gets implemented
in GL drivers.
BUG=457898
TEST=verify that UDL+i915 extended desktop has no artifacts
Review URL: https://codereview.chromium.org/942113006
TBR=alexst@chromium.org,dnicoara@chromium.org,spang@chromium.org
Cr-Commit-Position: refs/heads/master@{#318408}
(cherry picked from commit e0b8b9dfff8f5fa19aa0d039c6d1fecc96d113e6)
Review URL: https://codereview.chromium.org/968263004
Cr-Commit-Position: refs/branch-heads/2311@{#93}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Merge: Allow offsets in blobs larger than 2GB on 32 bit Chromium builds.
The recent patch crrev.com/895933007 introduced a regression by using size_t
for offsets, which on 32bit builds is sizeof(size_t) = 4 which was causing
broken offset values due to assigning a uint64_t variable to such variables.
This CL fixes that by simply converting the types to uint64_t.
TBR=michaeln@chromium.org # For merge.
TEST=*FileSystemProvider*BigFile* on a 32 bit build Chromium build with
chromeos=1.
BUG=375297, 458122
Review URL: https://codereview.chromium.org/959113002
Cr-Commit-Position: refs/heads/master@{#318808}
(cherry picked from commit f6629637feb3bbf186de75da8fe4028a5244389f)
Review URL: https://codereview.chromium.org/973723002
Cr-Commit-Position: refs/branch-heads/2311@{#92}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}
Merge: content: Disable ChildDiscardableSharedMemoryManager browser tests.
These tests are failing on some machines. The failures seem to be
test setup related rather than failures related to the specific
logic that these tests are trying to test.
BUG=459703
Review URL: https://codereview.chromium.org/928903004
Cr-Commit-Position: refs/heads/master@{#317913}
(cherry picked from commit c2b8ddd55bc67bce06171337275f66b99e72be12)
Review URL: https://codereview.chromium.org/969113003
Cr-Commit-Position: refs/branch-heads/2311@{#91}
Cr-Branched-From: 09b7de5dd7254947cd4306de907274fa63373d48-refs/heads/master@{#317474}