Publish DEPS for Chromium 44.0.2403.39
Incrementing VERSION to 44.0.2403.39
Cr-Commit-Position: refs/branch-heads/2403@{#242}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Merge M44: Use SingleParameterFormatter for settings override permissions.
The search provider, home page and start pages override permission
messages each take a parameter describing the URL that the setting
can be changed to. This was being properly handed in
settings_override_permission.cc but not in the message formatters in
chrome_permission_message_rules.cc.
This change also removes the duplicate rules for these permissions.
(Cherry-picked from commit c1f0c854d5c1ce20351d69a97f6538ed9acbd24c.)
BUG=496332
Review URL: https://codereview.chromium.org/1165553008
Cr-Commit-Position: refs/heads/master@{#333119}
R=rdevlin.cronin@chromium.org
Review URL: https://codereview.chromium.org/1168113002
Cr-Commit-Position: refs/branch-heads/2403@{#241}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Beacons for tracking default browser status.
BUG=488247
R=gab@chromium.org,wfh@chromium.org
Review URL: https://codereview.chromium.org/1146843003
Cr-Commit-Position: refs/heads/master@{#332423}
(cherry picked from commit 53cc88da9a258bc4a34c4bff50025ee044c2e64d)
TBR=grt@chromium.org
Review URL: https://codereview.chromium.org/1169843002
Cr-Commit-Position: refs/branch-heads/2403@{#240}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
[Autofill] Don't hold onto stale form field pointers
Delete old references when new form data is being parsed.
BUG=495102
Review URL: https://codereview.chromium.org/1161793006
Cr-Commit-Position: refs/heads/master@{#333168}
(cherry picked from commit bd002c0484db244b493d9eeb671d9476024c1b33)
Review URL: https://codereview.chromium.org/1168123002
Cr-Commit-Position: refs/branch-heads/2403@{#239}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Merge to M44: "Always post buffering state updates since they may change sink state."
The lock must never be held when OnTimeStateChanged() is calling into
the VideoRendererSink or we can deadlock the compositor thread.
With video-only playback occurs a buffering state change for underflow
would immediately invoke OnTimeStateChanged(false) which would try to
stop the VideoRendererSink under lock.
Also merges test fixes:
- http://crrev.com/332976
- http://crrev.com/333181
BUG=496466
TEST=video only playback doesn't deadlock.
TBR=xhwang
Review URL: https://codereview.chromium.org/1161463006
Cr-Commit-Position: refs/heads/master@{#332772}
(cherry picked from commit 9d8a53f3bf01aed28abbd1f9a713a25362c0d158)
Review URL: https://codereview.chromium.org/1165203002
Cr-Commit-Position: refs/branch-heads/2403@{#238}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
cc: Ensure that skewport.Contains(visible_rect) is always true.
This patch ensures that the skewport contains the visible rect. This
is a required that could be violated by extreme visible rects that
would overflow integer math. The fix is to add an extra union.
Includes a test.
TBR=enne
BUG=487130
Review URL: https://codereview.chromium.org/1131383007
Cr-Commit-Position: refs/heads/master@{#330600}
(cherry picked from commit 7923e436272f671334bc4d75edad97c67bc02212)
Review URL: https://codereview.chromium.org/1169703003
Cr-Commit-Position: refs/branch-heads/2403@{#237}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Merge into M44: Fix OverscrollWindowDelegate to not dispatch superfluous OverscrollModeChange events
Previously OverscrollWindowDelegate sometimes would call OnOverscrollModeChange on its delegate even if the overscroll mode didn't change. Specifically this happened for OVERSCROLL_NONE when an overscroll-cancelling condition such as a mouse move would occur.
This could confuse OverscrollWindowAnimation and make it cancel the overscroll animation which shouldn't have been cancelled. On Windows there is currently a mouse event dispatched after each swipe on the touch screen, so this caused crbug.com/493672.
BUG=493672
TBR=sadrul
Review URL: https://codereview.chromium.org/1167013002
Cr-Commit-Position: refs/heads/master@{#333049}
(cherry picked from commit 404f4d1ddaa75235e67a5f8a71ecc6ac8b2d65ec)
Review URL: https://codereview.chromium.org/1151423010
Cr-Commit-Position: refs/branch-heads/2403@{#236}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Merge into M44: Fixes the issue where overscroll animations were bleeding content over the browser window bounds.
The cause of the issue was that we were calling SetMasksToBounds(false) on the
web contents window's layer and its parent. The reason we were doing that was
that we wanted the screenshot to be captured for the entire page, not for
the visible part of it.
The fix is to get rid of SetMasksToBounds(false) and also to navigate only after
the overscroll animation finishes, not when it starts. This is unfortunate,
because it contributes to the perceived lag of the navigation, but this is
probably the best we can do for beta branch fix.
BUG=490817
TBR=sadrul
Review URL: https://codereview.chromium.org/1151723004
Cr-Commit-Position: refs/heads/master@{#331633}
(cherry picked from commit 43db64d9239b8965e2f9f741eebc3f0aa1616c76)
Review URL: https://codereview.chromium.org/1155493008
Cr-Commit-Position: refs/branch-heads/2403@{#235}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
[Extensions Page] Fix focus when an extension is removed
When an extension is removed, if an element was focused, the analogous element
on the previous/next extension should be focused.
BUG=479092
TBR=dbeam@chromium.org
Review URL: https://codereview.chromium.org/1138973005
Cr-Commit-Position: refs/heads/master@{#330547}
(cherry picked from commit 0da16bdaa81d0952a73153e74c7889a273b75a3b)
Review URL: https://codereview.chromium.org/1146013006
Cr-Commit-Position: refs/branch-heads/2403@{#234}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Web MIDI ALSA: Enable hardware based device matching
BUG=486471
TBR=agoode@chromium.org
Review URL: https://codereview.chromium.org/1145653002
Cr-Commit-Position: refs/heads/master@{#330941}
(cherry picked from commit 774a30f2010327ae6a94ea2a8bb57d030161b0da)
Review URL: https://codereview.chromium.org/1162833005
Cr-Commit-Position: refs/branch-heads/2403@{#233}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Incrementing VERSION to 44.0.2403.38
Cr-Commit-Position: refs/branch-heads/2403@{#232}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Incrementing VERSION to 44.0.2403.37
Cr-Commit-Position: refs/branch-heads/2403@{#231}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Replaced texcoord managed stride with pixel store UNPACK_ROW_LENGTH.
Removed stride texcoord management for now, replaced with using
UNPACK_ROW_LENGTH pixelStore instead. If performance becomes an issue
separate texcoords for Y and UV can be introduced instead.
BUG=493814
Review URL: https://codereview.chromium.org/1169473004
Cr-Commit-Position: refs/heads/master@{#332790}
(cherry picked from commit 247fa28e41b3fb6f5ab4ac7289a69bd1b29faf53)
TBR=sergeyu@chromium.org
Review URL: https://codereview.chromium.org/1156043008
Cr-Commit-Position: refs/branch-heads/2403@{#230}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Incrementing VERSION to 44.0.2403.36
Cr-Commit-Position: refs/branch-heads/2403@{#229}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Add InfoBarContainer observing capability.
BUG=495808
TBR=dtrainor@chromium.org
Part of "Disable Reader mode in fullscreen mode or when
infobars are shown" CL, split in two due to Chromium vs
downstream separation in M-44.
Review URL: https://codereview.chromium.org/1152013007
Cr-Commit-Position: refs/heads/master@{#333164}
(cherry picked from commit 901a3e766236ed08252799f3a5737f65568c4a49)
Review URL: https://codereview.chromium.org/1155183007
Cr-Commit-Position: refs/branch-heads/2403@{#228}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Disable return from idle notification on external displays and increase the idle timeout to 20 minutes.
BUG=369118
TBR=xiyuan
Review URL: https://codereview.chromium.org/1150243005
Cr-Commit-Position: refs/heads/master@{#332729}
Review URL: https://codereview.chromium.org/1153173010
Cr-Commit-Position: refs/branch-heads/2403@{#227}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Translate physical keyboard accents to IME compositions.
On other platforms, the OS IME system generates composition events for
combining characters like accents, but on Android it's the
responsibility of the textbox implementation to do so for physical
keyboards. This patch adds support for that.
This differs from the previous accent implementation
https://codereview.chromium.org/759033002 in that it uses IME
compositions. This is more similar to desktop platforms from the point
of view of Blink/Javascript (I've verified compositionUpdate events are
sent on Mac instead of keycodes), and it avoids complications arising from
artificial backspace characters.
To simplify the if/else blocks, this patch also changes to update
mEditable on ACTION_DOWN instead of up, which also better maps to when
Blink makes the change.
BUG=230921
Review URL: https://codereview.chromium.org/1162863007
Cr-Commit-Position: refs/heads/master@{#333150}
(cherry picked from commit 94e195a2beb75c16a984401707f679781308a413)
Review URL: https://codereview.chromium.org/1163243002
Cr-Commit-Position: refs/branch-heads/2403@{#226}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
[2403] Squashed: Stop losing tabs on startup crashes
Stop deleting the tab model metadata file immediately after loading.
Instead of immediately deleting the file on startup, hold onto it and
simply overwrite it when necessary. This prevents cases where Chrome
hasn't managed to read in all of the TabState files before a crash,
which results in total annihilation of the tabs on the next load.
BUG=485217
Review URL: https://codereview.chromium.org/1156343002
Cr-Commit-Position: refs/heads/master@{#331832}
Introduce TestTabModelDirectory for mocking out TabModel data.
Refactor the TabStateTest so that its data file mocking can be used for a
future CL:
https://chromiumcodereview.appspot.com/1159233002/
Also changes the TabStateTest to look at additional V2 TabStates, including ones
with Chinese and RTL characters.
BUG=485217
Review URL: https://codereview.chromium.org/1156023009
Cr-Commit-Position: refs/heads/master@{#332464}
Save tab metadata file with info about tabs still being loaded.
Depends on https://codereview.chromium.org/1156023009/
It's possible for Chrome to be told to write out information about
the TabModelSelector before the TabPersistentStore has had a chance
to load up all the TabStates from the previous session. In this
situation, the TabPersistentStore ends up writing an incomplete
list of Tabs from the two TabModels, resulting in tab loss. This
problem is compounded by the fact that the metadata file isn't
written again until the next time a TabState is dirty, or until
the user backgrounds Chrome.
Deal with this by writing out information about pending loads
in the metadata file after information about the TabModels has
been written. The version number of the save state file is
kept constant because the TabPersistentStore effectively gets
the same data, just ordered differently. Turns out that not keeping
an exact count of how many incognito or standard tabs there are
is beneficial in this case, since we just have a list of tabs
that need to be loaded.
This CL doesn't attempt to keep the ordering of the tabs
consistent between interrupted loads, nor does it try to load
the interrupted incognito tabs before the standard tabs. That
requires more careful stitching of the loaded and not-yet-loaded
tab lists, which is better suited to a follow up CL.
BUG=485217
Review URL: https://codereview.chromium.org/1159233002
Cr-Commit-Position: refs/heads/master@{#332735}
TBR=tedchoc,dtrainor
Review URL: https://codereview.chromium.org/1154343006
Cr-Commit-Position: refs/branch-heads/2403@{#225}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
branch 2403: Free context resources when memory limit is 0
Android webview does not use chrome's concept of visibility. Treat
memory being set to 0 as signal to drop memory. And drop memory by
flipping the surface to invisible and back.
BUG=496057
Review URL: https://codereview.chromium.org/1164083003
Cr-Commit-Position: refs/heads/master@{#333113}
(cherry picked from commit b032a08db9fbaedacaa5b0ac4d39374c4995839c)
TBR=boliu@chromium.org
Review URL: https://codereview.chromium.org/1162793005
Cr-Commit-Position: refs/branch-heads/2403@{#224}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Cherry pick Mac background renderers change for M44
Apply changes that enable backgrounding of renderer processes on the
Mac to M44. These changes landed in M45 and were approved for
cherry picking back to M44.
BUG=460102
Originally Committed: https://crrev.com/e3bb10f7860a1d553c85293bd7d7615c0e7f0fd9
Reverted: https://crrev.com/ce6226a7ffe2c1cb7ac5f6cf34b56b8d217686b9
Second commit: https://crrev.com/0160d130f8a4462fa7bfb8a9924e476d31ba9a48
Second revert: https://crrev.com/93ef7cd278d450b06f4a95fad6577d05b67624aa
Review URL: https://codereview.chromium.org/989703002
Cr-Commit-Position: refs/heads/master@{#332454}
(cherry picked from commit 8fbe9d3eb4ab56b0be87c3c4e04bb544ede982c7)
NOTRY=true
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1166983004
Cr-Commit-Position: refs/branch-heads/2403@{#223}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
[Merge to M44][Makes ChromeVox focus handling more resilient]
Adds an additional check to ensure the document has focus when processing focus events.
It is unclear if this logic should also apply to ther event types; when tried, ChromeVox broke in unexpected ways so scoping to only focus events.
BUG=488663
Review URL: https://codereview.chromium.org/1161003004
Cr-Commit-Position: refs/heads/master@{#332500}
(cherry picked from commit 561d4adf392045f68e557eac3be6075b608ba318)
Review URL: https://codereview.chromium.org/1151763012
Cr-Commit-Position: refs/branch-heads/2403@{#222}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
branch 2403: Lower mapped memory reclaim limit on low ram devices
BUG=496057
Review URL: https://codereview.chromium.org/1167963002
Cr-Commit-Position: refs/heads/master@{#332969}
(cherry picked from commit bfb86311963b4702b3e13ed4690357490a27f2d8)
TBR=boliu@chromium.org
Review URL: https://codereview.chromium.org/1157323004
Cr-Commit-Position: refs/branch-heads/2403@{#221}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Fix a bug where the desired size was passed to GetLargestRawFaviconForPageURL rather than the expected minimum size.
This caused smaller icons to be returned rather than large icons when the minimum size was 0, as used on Android.
BUG=482815
TBR=pkotwicz@chromium.org
Review URL: https://codereview.chromium.org/1145313008
Cr-Commit-Position: refs/heads/master@{#331831}
(cherry picked from commit 1f3defa5f05b2f43f5a1058fa59ff916ed38f62b)
Review URL: https://codereview.chromium.org/1170633003
Cr-Commit-Position: refs/branch-heads/2403@{#220}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
This change needs to go to branch 2403 (M44).
Revert "Converting (Alt+LeftClick -> RightClick) to (Search+LeftClick -> RightClick)" on behalf of afakhry@.
As seen in the buganizer discussion, users have gotten used to the broken behavior and are disrupted by the change without warning.
This reverts commit 404d0118fa4c40676cbd2f6da3e5ba5d62f39b61.
BUG=248762
TBR=afakhry@chromium.org
Review URL: https://codereview.chromium.org/1161853004
Cr-Commit-Position: refs/heads/master@{#332979}
(cherry picked from commit e54b1fc21cb1fbb5f4532009ad8181432761657c)
Review URL: https://codereview.chromium.org/1166533004
Cr-Commit-Position: refs/branch-heads/2403@{#219}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
[Merge to M44][Session restore] Add MRU logic to loading of background pages.
This patch adds the notion of last activation time to tabs and when a session restores, background tabs are loaded using MRU.
BUG=472772
Review URL: https://codereview.chromium.org/1131373003
Cr-Commit-Position: refs/heads/master@{#331189}
(cherry picked from commit 5582cbe405f6dc48b14e2cae7254aa03abcf353b)
Review URL: https://codereview.chromium.org/1161093007
Cr-Commit-Position: refs/branch-heads/2403@{#218}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
[Merge to M44] Revert of Change WebContents::last_active_time_ to Time instead of Timeticks. (patchset #1 id:140001 of https://codereview.chromium.org/1140083004/)
Reason for revert:
Reverting for georgesak@ (his committer access hasn't propagated yet it looks like).
After discussion with sky@, decided to keep TimeTicks.
Original issue's description:
> Change WebContents::last_active_time_ to Time instead of Timeticks.
>
> For context, last_active_time_ is going to be used by session restore to order the loading of background tabs using MRU. In order for this to be robust, last_active_time_ must be saved and restore between sessions. Timeticks cannot be reliably restored as it's dependent on the current OS session. MRU code for session restore is being implemented in https://codereview.chromium.org/1131373003
>
> Notes:
> - In dev tools, replaced "activity" with "active" for consistency
> - In OomPriorityManagerTest.Comparator, initialized last_active_time for all tabs, as this is necessary with Time (a default TimeTicks can go back in time, not the case with Time).
>
> BUG=472772
>
> Committed: https://crrev.com/041ef9c96d9a5b6f206a24385b0e6e4b3dbf9f20
> Cr-Commit-Position: refs/heads/master@{#330029}
TBR=jamescook@chromium.org,jam@chromium.org,georgesak@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=472772
Review URL: https://codereview.chromium.org/1145233002
Cr-Commit-Position: refs/heads/master@{#330778}
(cherry picked from commit 0dccfef67664a8304772e46696be7f15ee177419)
Review URL: https://codereview.chromium.org/1153083003
Cr-Commit-Position: refs/branch-heads/2403@{#217}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
url_matcher: Treat FQDN hosts as if they were relative.
This changes URLMatcher to not make a difference between
fully-qualified and relative URLs. Patterns that specify
fully-qualified host names now also match the corresponding relative
host name in URLs and fully-qualified host names in URLs now match
patterns that use relative host names.
BUG=chromium:493142
TEST=Added unit and browser test coverage.
Review URL: https://codereview.chromium.org/1167483002
Cr-Commit-Position: refs/heads/master@{#331963}
(cherry picked from commit d9cdcd8702111079c27787a2d49b48470bc10ae7)
TBR=battre@chromium.org
Review URL: https://codereview.chromium.org/1160993004
Cr-Commit-Position: refs/branch-heads/2403@{#216}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Incrementing VERSION to 44.0.2403.35
Cr-Commit-Position: refs/branch-heads/2403@{#215}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Stop bookmark apps generating icons when larger icons are available.
At display time, bookmark apps automatically downscale larger icons to
fit smaller requested sizes. However, this doesn't happen if a custom icon
is generated at installation time. This CL fixes an issue where custom
icons are always generated for sizes which are not provided by the
site, potentially leading to that custom icon being used for the shelf
even though a larger one from the site is available.
TBR=calamity@chromium.org
BUG=494822
Review URL: https://codereview.chromium.org/1165643003
Cr-Commit-Position: refs/heads/master@{#332497}
(cherry picked from commit f91c05385b1e2c27fd7360fdde3e4ea20c378be1)
Review URL: https://codereview.chromium.org/1148683011
Cr-Commit-Position: refs/branch-heads/2403@{#214}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Merge to branch 2403 [M44] [Password Manager] Fix incorrect saving when autofill and generation both trigger
If the password manager fills a field and generation triggers for the same field,
currently we will not correctly update the password that is entered in the field.
This means that if the user enters a different password than was autofilled, the
new saved password will be incorrect.
There are two specific changes here:
- Update PasswordAutofillAgent's state when text changes regardless of if it is
allowed to show a popup.
- Specifically inform PasswordAutofillAgent when a generated password is accepted
as this text change is dropped as it looks like script updating the page.
Eventually we should not autofill into fields that generation triggers on, since
we don't want to fill old data into a signup form. That change is more involved
thought.
TBR=sky@chromium.org
BUG=493455
Review URL: https://codereview.chromium.org/1154153004
Cr-Commit-Position: refs/heads/master@{#332733}
(cherry picked from commit 5c13d76a088a244b93b3d05c76d0709d2d5a0be7)
Review URL: https://codereview.chromium.org/1166983008
Cr-Commit-Position: refs/branch-heads/2403@{#213}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
[Android] Add enhanced bookmarks grid/list view experiment
BUG=490717
Review URL: https://codereview.chromium.org/1143153010
Cr-Commit-Position: refs/heads/master@{#332957}
(cherry picked from commit 5bd609076d410cbaf47ec94ec61414af26134f46)
TBR=tedchoc@chromium.org
Review URL: https://codereview.chromium.org/1171503002
Cr-Commit-Position: refs/branch-heads/2403@{#212}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Incrementing VERSION to 44.0.2403.34
Cr-Commit-Position: refs/branch-heads/2403@{#211}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
swapContentViewCore is used by the Reader mode panel
BUG=473205
TBR=tedchoc@chromium.org
Review URL: https://codereview.chromium.org/1147783002
Cr-Commit-Position: refs/heads/master@{#330575}
(cherry picked from commit 8c002aa881be89f010166c786e50cd778f587701)
Review URL: https://codereview.chromium.org/1170543002
Cr-Commit-Position: refs/branch-heads/2403@{#210}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Merge to M44: When serializing accessibility tree, skip invalid children.
See bug for specific repro in the wild, but essentially we need to check
if the child is valid just before serializing, and not trust the list of
children of a node.
BUG=479743
Review URL: https://codereview.chromium.org/1144363004
Cr-Commit-Position: refs/heads/master@{#332748}
(cherry picked from commit 8dc07f045c6287da3404fa8e0fd8b1b3960afbfa)
Review URL: https://codereview.chromium.org/1161103004
Cr-Commit-Position: refs/branch-heads/2403@{#209}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Merge to M44: An accessibility tree update with two roots should be rejected.
If an AXTreeUpdate had two root nodes, the second one would cause the
first one to be deleted, but that could leave dangling pointers in
|pending_nodes|. Fix this by first ensuring that |pending_nodes| is
always cleaned up when nodse are deleted, but also by specifically
returning an error if we encounter two root nodes since that should
never happen.
BUG=479743
Review URL: https://codereview.chromium.org/1151393006
Cr-Commit-Position: refs/heads/master@{#332212}
(cherry picked from commit e3b7faf115bcd4fec56b1658e60abe077d77f379)
Review URL: https://codereview.chromium.org/1156503007
Cr-Commit-Position: refs/branch-heads/2403@{#208}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Hard-code modifier key codes since the header file that defines them was not merged.
BUG=492808
R=garykac@chromium.org
Review URL: https://codereview.chromium.org/1150383005
Cr-Commit-Position: refs/branch-heads/2403@{#207}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Updating XTBs based on .GRDs from branch 2403
Cr-Commit-Position: refs/branch-heads/2403@{#206}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Expose the history merge primitives to Java
Exposes CopyStateFrom, CopyStateFromAndPrune and
CanPruneAllButLastCommitted to Java.
This is enough to merge the history when swapping
the web contents on a tab.
BUG=473205
TBR=sievers@chromium.org
Review URL: https://codereview.chromium.org/1157433011
Cr-Commit-Position: refs/heads/master@{#332774}
(cherry picked from commit b47a7a3f6b93ddacfa3dff419b0bc56512b2dd5c)
Review URL: https://codereview.chromium.org/1146173008
Cr-Commit-Position: refs/branch-heads/2403@{#205}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Merge to branch 2403 [M44] [Smart Lock] Update UI for Android password generation confirmation
BUG=486739
Review URL: https://codereview.chromium.org/1144583002
Cr-Commit-Position: refs/heads/master@{#332039}
(cherry picked from commit c797da3abf3e86a7f3c7720f90a1bbd4fb7d63a9)
Review URL: https://codereview.chromium.org/1160253007
Cr-Commit-Position: refs/branch-heads/2403@{#204}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
[Extensions UI Views] Fix page action context menus
Fix a bug where page action views weren't wired up to show their context menus, and add a test to prevent regression.
BUG=493847
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/1155243008
Cr-Commit-Position: refs/heads/master@{#332630}
(cherry picked from commit f2253f07559dfc42172fce26d7e6a0b3aa6e0798)
Review URL: https://codereview.chromium.org/1169573002
Cr-Commit-Position: refs/branch-heads/2403@{#203}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Only enforce default notifications when no more push events are in-flight.
If a series of push events are being handled simultaneously for any
given app id, we should only enforce the default notification
requirements after the last event has finished. This should reduce
flakiness in determining whether the default notification should
be displayed.
TBR=pennymac, johnme, miguelg
BUG=495177
Review URL: https://codereview.chromium.org/1164713009
Cr-Commit-Position: refs/heads/master@{#332411}
(cherry picked from commit 60204505b056764ed4086bc8c318571bde8ba3c6)
Review URL: https://codereview.chromium.org/1165973003
Cr-Commit-Position: refs/branch-heads/2403@{#202}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Suppress modifier key auto-repeat on Linux.
Linux hosts synthesize keyup events between auto-repeated keydown
events, which is the wrong thing to do in the case of modifier keys.
BUG=492808
TBR=wez@chromium.org
Review URL: https://codereview.chromium.org/1161173003
Cr-Commit-Position: refs/heads/master@{#332637}
(cherry picked from commit 462f3acb1e1a4bec37334406d2bfd4d3c2c116ae)
Review URL: https://codereview.chromium.org/1158233007
Cr-Commit-Position: refs/branch-heads/2403@{#201}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Automatically close the default push notification when a real one appears.
When the developer shows a notification themselves in response to
an incoming push message, and a default notification still happens
to stick around from a previous message where they forgot to do so,
the default notification should be closed automagically.
TBR=pennymac, johnme
BUG=495175
Review URL: https://codereview.chromium.org/1149243005
Cr-Commit-Position: refs/heads/master@{#332387}
(cherry picked from commit ed53734f33844f3d1c182dc18cf6d808d0221e60)
Review URL: https://codereview.chromium.org/1170533002
Cr-Commit-Position: refs/branch-heads/2403@{#200}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Merge to M44: Fix Mac textarea accessibility regression
Change crrev.com/324212 got rid of separate internal roles for text
fields and text areas, but it accidentally also eliminated code
that checked the Mac OS X role, where the TextArea role is still
used for multi-line text fields. This change adds those checks back.
BUG=493559
Review URL: https://codereview.chromium.org/1162703002
Cr-Commit-Position: refs/heads/master@{#332227}
(cherry picked from commit 1689b18ee202314b58ca9608a3cdc4ea8b64eef8)
Review URL: https://codereview.chromium.org/1150053008
Cr-Commit-Position: refs/branch-heads/2403@{#199}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
BrowserWindowCocoa::Show should activate the window
When a new tab/window is opened on Mac, the window is currently brought
to the front relative to other Chrome windows, but not relative to other
apps. This often goes unnoticed, since Chrome is often already the
active app, but it's particularly noticeable when clicking on a push
notification opens a new tab/window, as this window will remain
underneath other apps if Chrome wasn't already in the foreground.
This patch makes Show always Activate the window as well.
BUG=470830
TEST=manual, follow steps in https://crbug.com/470830
TBR=avi@chromium.org
Review URL: https://codereview.chromium.org/1166643003
Cr-Commit-Position: refs/heads/master@{#332615}
(cherry picked from commit b13b6d7b2c7ad67c1b1937897fe3c26527eeb943)
Review URL: https://codereview.chromium.org/1165973002
Cr-Commit-Position: refs/branch-heads/2403@{#198}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Files.app: Store thumbnailUrl from external metadata provider only when it is requested or gotten.
Storing 'undefined' value when the thumbnail url is not requested will result
in missing thumbnails on FSP volumes.
This CL fixes the issue by storing metadata only when it is requested or gotten
without request.
We should apply the same treatment for all properties, but this CL do it only
for thumbnailUrl to minimize the impact and prepare for merge.
For more context, please see the comments in http://crrev.com/1158463004
BUG=489595, 494910
TEST=Install TED talks extension, switch to grid view, and check thumbnails exist.
TBR=hirono@chromium.org
Review URL: https://codereview.chromium.org/1144393007
Cr-Commit-Position: refs/heads/master@{#332532}
(cherry picked from commit 60cd0f79fd0f3065c2f5a1f44e19d99a09fd8888)
Review URL: https://codereview.chromium.org/1155453006
Cr-Commit-Position: refs/branch-heads/2403@{#197}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
String for ChromeVox prompt at login
BUG=496365
As an alternative to fixing this bug for M-44, we're adding a voice
label to prompt a ChromeVox user to use TAB to navigate login elements.
This is just the string component of that, to get translation started.
Review URL: https://codereview.chromium.org/1165613005
Cr-Commit-Position: refs/heads/master@{#332727}
(cherry picked from commit 969b033beb375dee99fd01aaab2a063465fc94c4)
Review URL: https://codereview.chromium.org/1145403007
Cr-Commit-Position: refs/branch-heads/2403@{#196}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Incrementing VERSION to 44.0.2403.33
Cr-Commit-Position: refs/branch-heads/2403@{#195}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Merge into 44: cc: Video layers without a frame should not occlude
Added VisibleContentOpaqueRegion() to the VideoLayerImpl, if
a frame hasn't been set yet, then we don't have an opaque region.
+ test
BUG=460612
TBR=danakj, dalecurtis
Review URL: https://codereview.chromium.org/1134663005
Merge URL: https://codereview.chromium.org/1166843003/
Cr-Commit-Position: refs/heads/master@{#330449}
(cherry picked from commit e19cc6a61419d38f3ec658c5e74363d77e900c09)
Review URL: https://codereview.chromium.org/1166843003
Cr-Commit-Position: refs/branch-heads/2403@{#194}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
[Autofill] Update user-facing strings for server cards
BUG=490338
TBR=tedchoc@chromium.org
Review URL: https://codereview.chromium.org/1163693004
Cr-Commit-Position: refs/heads/master@{#332041}
(cherry picked from commit 95462a7cdd681b583d32028537973cd63dc3e681)
Review URL: https://codereview.chromium.org/1163713006
Cr-Commit-Position: refs/branch-heads/2403@{#193}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
[M44 merge] Run python update_extension_permission.py
extensions\common\permissions\api_permission.h had a value added (on
May 11 for bug 485227) that threw off the numbering. Move it to the
bottom. We should probably also merge this to the branch.
BUG=485227
NOPRESUBMIT=true
NOTRY=true
Original Review URL: https://codereview.chromium.org/1153503003
Original Cr-Commit-Position: refs/heads/master@{#332286}
Conflicts:
extensions/common/permissions/api_permission.h
Review URL: https://codereview.chromium.org/1156553005
Cr-Commit-Position: refs/branch-heads/2403@{#192}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Merge M44: Disable Win32k renderer lockdown if NPAPI is manually enabled.
BUG=490815,455893
Review URL: https://codereview.chromium.org/1162403002
Cr-Commit-Position: refs/heads/master@{#332629}
(cherry picked from commit ad38f5a347cfc28f835b27000560608fdd3bcf0e)
Review URL: https://codereview.chromium.org/1163463006
Cr-Commit-Position: refs/branch-heads/2403@{#191}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
cc: Allow synchronous compositor to PrepareTiles on each draw.
In OOM situations tiles which are not rasterizied by TileManager are
marked as rasterize on demand. This means that on the next draw we will
ask for PrepareTiles again. This can cause issues with the synchronous
compositor in certain situations where we receive two draws every vsync
and end up setting needs_prepare_tiles_ in each frame and asking for
vsyncs indefinitely.
To prevent this we allow the synchronous compositor to call PrepareTiles
on each draw so that needs_prepare_tiles_ is never true after a draw and
we don't unnecessarily ask for vsyncs.
BUG=495260
R=boliu@chromium.org,mithro@chromium.org,brianderson@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1163013002
Cr-Commit-Position: refs/heads/master@{#332542}
(cherry picked from commit c71f951615afa8969b8cf4a773e425defa4eb089)
Review URL: https://codereview.chromium.org/1165903004
Cr-Commit-Position: refs/branch-heads/2403@{#190}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Merge M44: Revert ICU plural syntax changes in device_permissions_prompt.cc.
In commit ec68f03e4f4be911752b005fb82b9e49acafea51 the strings used to
populate the heading of the device chooser were changed to use the new
ICU plural syntax. This change had two issues. First, the strings for
HID and USB devices were swapped. Second, the decision on which string
to use was based on devices_.size() instead of the multiple() flag. This
meant that the "zero" message was the only one ever displayed. The
plural syntax is also the wrong mechanism to choose between these
messages because there are only two choices: 1 and more than 1.
This change reverts those changes.
(Cherry-picked from commit e3c37b31e826cd26005fbedb1227984d1711aae3.)
BUG=495839
Review URL: https://codereview.chromium.org/1151523010
Cr-Commit-Position: refs/heads/master@{#332652}
R=mek@chromium.org
Review URL: https://codereview.chromium.org/1160543005
Cr-Commit-Position: refs/branch-heads/2403@{#189}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Guard against null pointer ThumbnailCache being destroyed.
BUG=490312
NOTRY=true
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1161703002
Cr-Commit-Position: refs/heads/master@{#332231}
(cherry picked from commit dcdece34e053fd1684cf5aeb41b5accb9106a033)
Review URL: https://codereview.chromium.org/1158153004
Cr-Commit-Position: refs/branch-heads/2403@{#188}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
[Android] Restore "MobilePullGestureReload" action recording
Recording of this action was accidentally removed with the refresh
effect overhaul in https://codereview.chromium.org/894193005.
Restore it accordingly.
BUG=492256
Review URL: https://codereview.chromium.org/1148953010
Cr-Commit-Position: refs/heads/master@{#332304}
(cherry picked from commit a84cc81957ecfabe8fc5c4bb1db22445e5c8a157)
Review URL: https://codereview.chromium.org/1142283005
Cr-Commit-Position: refs/branch-heads/2403@{#187}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Now handles SRT runs that completed later.
BUG=493266
Review URL: https://codereview.chromium.org/1154943003
Cr-Commit-Position: refs/heads/master@{#332110}
(cherry picked from commit 4df6c444f94ea30a5b4695e6cd5ca57b7f944c0b)
Review URL: https://codereview.chromium.org/1162993003
Cr-Commit-Position: refs/branch-heads/2403@{#186}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
[Merge to M44] Move password_manager_util and password_bubble_experiment to components
This merges https://codereview.chromium.org/1133613007 to branch 2403 (M44). Approval in http://crbug.com/493661#c6.
Original description:
----------------------------------------------------
BUG=486739
Review URL: https://codereview.chromium.org/1133613007
Cr-Commit-Position: refs/heads/master@{#330905}
----------------------------------------------------
TBR=vabr@chromium.org
BUG=493661
(cherry picked from commit 205d8da3ff51ec789abcef187191b9a82519b9b2)
Review URL: https://codereview.chromium.org/1164003003
Cr-Commit-Position: refs/branch-heads/2403@{#185}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
[Merge to M44] Prepare password_bubble_experiment and password_manager_util for componentisation
This merges https://codereview.chromium.org/1141413002 to branch 2403 (M44).
The approval is at http://crbug.com/493661#c6.
Original description:
-------------------------------------------
This CL removes some unneeded //chrome dependencies in password manager utilities. The goal is to make those files movable to the password manager component. The move will happen in a separate CL.
BUG=486739
Review URL: https://codereview.chromium.org/1141413002
Cr-Commit-Position: refs/heads/master@{#330805}
-------------------------------------------
TBR=vabr@chromium.org
(cherry picked from commit 465933b5e78eca669273df5f1ef5351e2cd3cbf5)
Review URL: https://codereview.chromium.org/1156253006
Cr-Commit-Position: refs/branch-heads/2403@{#184}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Fix color pickers on WebView.
Instead of getting the activity from the WindowAndroid to use as a
context, just get the context from the ContentViewCore. In WebView,
contexts must be wrapped to enable proper class lookup for custom view
classes defined in the WebView APK and using the Activity directly was
circumventing the wrapper, causing color pickers to crash.
BUG=490616
Review URL: https://codereview.chromium.org/1156883004
Cr-Commit-Position: refs/heads/master@{#332418}
(cherry picked from commit 2046d4f5a4bde936c772262f73eb91d62f100b5b)
Review URL: https://codereview.chromium.org/1156303009
Cr-Commit-Position: refs/branch-heads/2403@{#183}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
[Merge to M44] [Smart Lock] Update strings for Save Passwords page on Android.
This merges https://codereview.chromium.org/1135333006/ to branch 2403 (M44).
Approval is at http://crbug.com/493666#c5.
TBR=engedy@chromium.org
BUG=486739
Review URL: https://codereview.chromium.org/1135333006
Cr-Commit-Position: refs/heads/master@{#330251}
(cherry picked from commit 123b175fbb872dbe57f07c921bdadb138a058b2d)
Review URL: https://codereview.chromium.org/1168503004
Cr-Commit-Position: refs/branch-heads/2403@{#182}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
chrome_official_builder_no_unittests depends on net_unittests, not net_unittests_run
R=vadimsh@chromium.org,pennymac@chromium.org
BUG=495677
Review URL: https://codereview.chromium.org/1164523007
Cr-Commit-Position: refs/heads/master@{#332547}
(cherry picked from commit 6d57c05c2154745bd5e814df13ee20e020978a57)
Review URL: https://codereview.chromium.org/1158013005
Cr-Commit-Position: refs/branch-heads/2403@{#181}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Incrementing VERSION to 44.0.2403.32
Cr-Commit-Position: refs/branch-heads/2403@{#180}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Avoid creating 0-byte SharedMemory in OutputDeviceBacking::GetSharedMemory()
That fails, causing Chrome to crash.
BUG=493256
TBR=piman@chromium.org
Review URL: https://codereview.chromium.org/1161753005
Cr-Commit-Position: refs/heads/master@{#332255}
(cherry picked from commit f453038583f8c9bd1ff5493c90b62c3cf5d81b78)
Review URL: https://codereview.chromium.org/1154803006
Cr-Commit-Position: refs/branch-heads/2403@{#179}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Add style information (font size, bold, italic, etc) and color to the snapshot.
BUG=490893
Review URL: https://codereview.chromium.org/1137393003
Cr-Commit-Position: refs/heads/master@{#332082}
(cherry picked from commit 2fe5ccafafe4419c2c5c6a827b50a1d027057fb1)
Review URL: https://codereview.chromium.org/1165793005
Cr-Commit-Position: refs/branch-heads/2403@{#178}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
[Android] Fix pull-to-refresh animation for RTL layouts
For RTL layouts, anchor the canvas scale to the image center when
drawing the pull-to-refresh animation.
BUG=495757
NOTRY=true
Review URL: https://codereview.chromium.org/1165793004
Cr-Commit-Position: refs/heads/master@{#332457}
(cherry picked from commit 793efc62d525292270206a31fbbd2ab35c4ea7ca)
Review URL: https://codereview.chromium.org/1156483008
Cr-Commit-Position: refs/branch-heads/2403@{#177}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Work around WebKeyboardEvent.domCode not being set on OS X.
BUG=493435
TBR=bbudge
Review URL: https://codereview.chromium.org/1156303007
Cr-Commit-Position: refs/heads/master@{#332229}
(cherry picked from commit 613cf4c983b05e0639bdd9b5cbba71296c6b7d97)
Review URL: https://codereview.chromium.org/1167543007
Cr-Commit-Position: refs/branch-heads/2403@{#176}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Merge into M44: Fixing a crash that happens when a tab is closed while an overscroll animation is in progress
BUG=486633
TBR=sadrul@chromium.org
Review URL: https://codereview.chromium.org/1150073002
Cr-Commit-Position: refs/heads/master@{#331621}
(cherry picked from commit 54f0801d48b02d95b0bfd8c85569f1b37e41920d)
Review URL: https://codereview.chromium.org/1158983004
Cr-Commit-Position: refs/branch-heads/2403@{#175}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
branch 2403: Fix avoid texture re-use workaround
The optimization for avoiding unncessary glEGLImageTargetTexture2DOES
does not apply when the workaround to never re-use textures is in effect
since texture is never re-used and must always be bound again.
BUG=492315
Review URL: https://codereview.chromium.org/1145893006
Cr-Commit-Position: refs/heads/master@{#332291}
(cherry picked from commit 4550fb9fa101cf390af8d329b8029831b5975ff8)
TBR=boliu@chromium.org
Review URL: https://codereview.chromium.org/1164813003
Cr-Commit-Position: refs/branch-heads/2403@{#174}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
branch 2403: Avoid unncessary EGLImageTargetTexture calls
EGLImageTargetTexture is expensive on some drivers, and can be skipped
if a texture is already bound to the EGLImage.
BUG=492315
Review URL: https://codereview.chromium.org/1159293002
Cr-Commit-Position: refs/heads/master@{#332100}
(cherry picked from commit 043650c4a2dcb8f2be4a42781c090bb18d5d77f6)
TBR=boliu@chromium.org
Review URL: https://codereview.chromium.org/1155533003
Cr-Commit-Position: refs/branch-heads/2403@{#173}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
branch 2403: Update texture version in PullTextureUpdates
This line got accidentally dropped in
https://codereview.chromium.org/1153313003/ and causing huge perf
regressions.
BUG=492315
Review URL: https://codereview.chromium.org/1163623002
Cr-Commit-Position: refs/heads/master@{#331995}
(cherry picked from commit 698b0298df3a08b942a384a04d755df278cbf319)
TBR=boliu@chromium.org
Review URL: https://codereview.chromium.org/1169433003
Cr-Commit-Position: refs/branch-heads/2403@{#172}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
branch 2403: Move eglCreateImageKHR in ProduceTexture out of lock
eglCreateImageKHR is expensive in some drivers. Move the call in
ProduceTexture out of the lock to reduce lock contention.
BUG=492315
Review URL: https://codereview.chromium.org/1156493008
Cr-Commit-Position: refs/heads/master@{#331902}
(cherry picked from commit 54a15ddb2f34f95dae482d56e42855be694ae79c)
TBR=boliu@chromium.org
Review URL: https://codereview.chromium.org/1153383006
Cr-Commit-Position: refs/branch-heads/2403@{#171}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
branch 2403: Update texture outside of lock
The glEGLImageTargetTexture2DOES call is expensive on some
drivers. Move these calls in PullTextureUpdates outside of
the global lock to reduce lock contention.
Also change makes glFlush to onces per PullTextureUpdates
instead of once per texture update.
BUG=492315
Review URL: https://codereview.chromium.org/1153313003
Cr-Commit-Position: refs/heads/master@{#331874}
(cherry picked from commit 909d78fa0bb097423165bc00eb1fa23ff15235c2)
TBR=boliu@chromium.org
Review URL: https://codereview.chromium.org/1168513002
Cr-Commit-Position: refs/branch-heads/2403@{#170}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Improve the default browser settings dialog for Win10
On Win10 the current approach of SHOpenWithDialog is suboptimal. See
the bug for more details.
BUG=488774,489803
Review URL: https://codereview.chromium.org/1140293002
Cr-Commit-Position: refs/heads/master@{#330596}
(cherry picked from commit 8707fef05b454ec373cb05d8a9f815780281ad2b)
TBR=cpu@chromium.org
Review URL: https://codereview.chromium.org/1152923006
Cr-Commit-Position: refs/branch-heads/2403@{#169}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Incrementing VERSION to 44.0.2403.31
Cr-Commit-Position: refs/branch-heads/2403@{#168}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
StatusUploader now tracks if we've captured media in this session.
Updated StatusUploader::IsSessionDataUploadAllowed() to return false if any
audio/video capture has occurred during this session.
Also added unit tests to test behavior in the presence of user input (mouse
presses).
BUG=487261
TBR=cschuet@chromium.org
Review URL: https://codereview.chromium.org/1151863004
* Merge to 2403 branch *
Cr-Commit-Position: refs/heads/master@{#331375}
(cherry picked from commit ecda113a811f188b1bb4174fa0ab8d2b240c3147)
Review URL: https://codereview.chromium.org/1151373007
Cr-Commit-Position: refs/branch-heads/2403@{#167}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Check the existence of provider_host and active_version in ServiceWorkerURLRequestJob::StartRequest()
They could be null when ServiceWorkerURLRequestJob::StartRequest() is called.
BUG=491768
Review URL: https://codereview.chromium.org/1153033002
Cr-Commit-Position: refs/heads/master@{#331500}
(cherry picked from commit 9b46187de99621f3da730b0a97c9837c0af5d447)
R=nhiroki@chromium.org
Review URL: https://codereview.chromium.org/1161313006
Cr-Commit-Position: refs/branch-heads/2403@{#166}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Dismiss browser plugin modal dialogs when the embedder needs to.
Test from wjmaclean@. PDF simply shows an alert dialog using script.
TBR=nasko,sky
BUG=482380
TEST=See bug for repro steps.
NOTRY=true
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1150843002
Cr-Commit-Position: refs/heads/master@{#331584}
(cherry picked from commit 89a0f782193755ad7a0b93c58dbcc1b96528405f)
Review URL: https://codereview.chromium.org/1153873005
Cr-Commit-Position: refs/branch-heads/2403@{#165}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}
Handle gamepad length being incorrectly set to 0 even when gamepad is present
When Windows sends device changed event multiple times even when a single
gamepad is connected, EnumerateDevices incorrectly sets gamepad length to zero.
BUG=485507
R=scottmg, raymes
TBR=bajones
Review URL: https://codereview.chromium.org/1145063004
Cr-Commit-Position: refs/heads/master@{#331822}
(cherry picked from commit bc4f7fa505a2d59a434d8a164043210a960d9be9)
Review URL: https://codereview.chromium.org/1166713003
Cr-Commit-Position: refs/branch-heads/2403@{#164}
Cr-Branched-From: f54b8097a9c45ed4ad308133d49f05325d6c5070-refs/heads/master@{#330231}