commit | 7fa981a9fedeb3247ff04f11becac83590d91c8b | [log] [tgz] |
---|---|---|
author | Ahmed Fakhry <afakhry@chromium.org> | Thu Dec 02 17:53:55 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Dec 02 17:53:55 2021 |
tree | 02967a439dab1f0dfe0270a67c0a9b16c44368fd | |
parent | 0d3ea8e82ac5d30382a473c06eba1114f66552ba [diff] |
[Merge to M-96] capture mode: Fix UAF when a dimmed widget is closed When a widget gets activated on top of the recorded window, it gets dimmed. When the widget is closed, it loses activation but is not removed from the window hierarchy until its native widget is actually deleted when the animation finishes. When its window dimmer is destroyed in OnWindowDestroying(), we must be careful not to access any of its members so as not to trigger a use-after-free. (cherry picked from commit 84d60042e8b182b055e91645ec94e7c7a08a2f93) Fixed: 1273197 Test: Manually, added a new test that triggers the ASAN failure. Change-Id: I7ae89c5ec9b4790522b3d58623f2dab222cbdd75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3308201 Reviewed-by: Min Chen <minch@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#946566} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312743 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Ahmed Fakhry <afakhry@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4664@{#1205} Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.