[go: up one dir, main page]

Store SHA-256 hash of wire bytes for WASM V8 Code Cache

This CL stores and validates SHA-256 hash of wire bytes
in WASM V8 Code Cache to prevent mismatches between
wire bytes and code cache metadata.

When hitting code cache, this CL calculates the hash
while streaming wire bytes, and
invalidates the code cache metadata on hash mismatch,
by setting `can_use_compiled_module` to `false`
in `WasmStreaming::Finish()`.

The cached metadata is passed to V8 by
`SetCompiledModuleBytes()` when the first bytes of
the wire bytes are received, but this only triggers
suppressiong of streaming compilation and the
content of the cached metadata is not used until
`WasmStreaming::Finish(true)` is called later.

This CL also adds tracing events to measure hashing overhead
and observe cache rejection by hash mismatch.

This CL depends on V8 side CL:
https://chromium-review.googlesource.com/c/v8/v8/+/3297548

(cherry picked from commit 7077e03a4e02c198ac9fdb0814d195df7a75c229)

Bug: 1260939
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3282643
Cr-Original-Commit-Position: refs/heads/main@{#944867}
No-Try: true
Change-Id: If074cbeeb7015a359566821cae544ff8f1cd3589
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310065
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/branch-heads/4664@{#1207}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
3 files changed
tree: 9b3b8acd60fd4bec4fd619cd4d105e3b151a44a7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.