[go: up one dir, main page]
Google Git
Sign in
chromium / chromium / src / 702172870bb23515d432784eae4017f12eb504f7
commit702172870bb23515d432784eae4017f12eb504f7[log] [tgz]
authorarthursonzogni <arthursonzogni@chromium.org>Sun Jan 31 04:55:09 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sun Jan 31 04:55:09 2021
tree0de053efec8cf06d2975b631e34356ea316ad0c9
parentef47868c5167a0e032489912bb8f557e66e548bb [diff]
Fix download of MHTML document.

Trivial fix and regressions tests. To be cherry-picked into M89 beta.

A page mustn't mix MHTML documents with regular documents. It would be
a security issue. The browser process is in charge of blocking those.
When moving the check outside of blink, a regressions has been
introduced: navigation that produce a download shouldn't be blocked.

R=​​antoniosartori@chromium.org
CC=​​​​​​ericlaw@microsoft.com,dcheng@chromium.org

(cherry picked from commit 00f90c402bb81c16be5bd825ec11783e8b51731e)

Bug: 1171765,1170484
Change-Id: I090076743b9ef8077a74bef7b2a75b54da8af307
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2659061
Reviewed-by: Eric Lawrence [MSFT] <ericlaw@microsoft.com>
Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#848740}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2661415
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Srinivas Sista <srinivassista@chromium.org>
Cr-Commit-Position: refs/branch-heads/4324@{#2075}
Cr-Branched-From: c73b5a651d37a6c4d0b8e3262cc4015a5579c6c8-refs/heads/master@{#827102}
2 files changed
tree: 0de053efec8cf06d2975b631e34356ea316ad0c9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.