commit | e187d0a20906511906cfb160e85da1a3a81d989a | [log] [tgz] |
---|---|---|
author | Ian Kilpatrick <ikilpatrick@chromium.org> | Tue Nov 30 17:41:49 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Nov 30 17:41:49 2021 |
tree | 32efb255f049c153bf804ef86937a30d6f49a888 | |
parent | 7e2bee1a6992aea30fc134477b1192549e430a94 [diff] |
[GridNG] Mitigate perf issue w/ replaced elements and block-constraints. This is effectively a revert of: https://chromium-review.googlesource.com/c/chromium/src/+/3154713 This change made us correct on the newly added test: grid-intrinsic-size-dynamic-block-size.html However this has large performance issues on sites with a replaced element embedded somewhere in a nested-grid structure with a dependence on block-constraints. This patch mitigates the issue, to properly solve this we need additional cache slots for both Layout, and ComputeMinMaxSizes (see crbug.com/1272533). (cherry picked from commit 90c957f7f80adb9dd496b816e8d03b87dadfb1f7) Bug: 1271648, 1272533 Change-Id: I37bede27f2a7988304ec11a37c75f763c79a50e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295042 Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by: Daniel Libby <dlibby@microsoft.com> Cr-Original-Commit-Position: refs/heads/main@{#944159} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3308392 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/branch-heads/4664@{#1190} Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.