[go: up one dir, main page]
Google Git
Sign in
chromium / chromium / src / d6150053d00425a3a870c1de029a5da9dc30c77a
commitd6150053d00425a3a870c1de029a5da9dc30c77a[log] [tgz]
authorScott Little <sclittle@chromium.org>Fri Jul 08 17:48:26 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jul 08 17:48:26 2022
treed466128d3cc3fb1ead33e364edc1dc6da49323fe
parent7494cc82836016b575a3840d3dd8031ac967e616 [diff]
Avoid creating a Java TranslateMessage with a null MessageDispatcher.

This CL causes the Java TranslateMessage::create() call to return null
if no MessageDispatcher is available, and changes the C++
TranslateMessage to avoid trying to show any translate message UI in
this case.

This fixes a possible NPE that can occur if
MessageDispatcherProvider.from() returns null, which can happen when the
activity is being recreated or destroyed.

(cherry picked from commit efaa81224576b5f45a23c4ad06c718a802141a7f)

Bug: 1333959
Change-Id: I15825f1a3b3c1d04992f2dd6e0eb5afa1fe82c9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3732539
Reviewed-by: Trevor Perrier <perrier@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1019207}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3753001
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/branch-heads/5112@{#699}
Cr-Branched-From: b13d3fe7b3c47a56354ef54b221008afa754412e-refs/heads/main@{#1012729}
4 files changed
tree: d466128d3cc3fb1ead33e364edc1dc6da49323fe
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.