commit | cab502c54f14d6c4839909b0c218b128a1949e91 | [log] [tgz] |
---|---|---|
author | Rodney Ding <rodneyding@google.com> | Wed Nov 24 22:18:32 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Nov 24 22:18:32 2021 |
tree | d94c95ec6b3f74f8d5ab570cc8e7bcc218a794ce | |
parent | c5c0a3bbbd92182a0c95643db8a26bdd7da74f36 [diff] |
[M96 Merge]Fix coop reporter not inheriting reporting source. - Previously we overwrite coop reporter's reporting source in the RFHI::SetCrossOriginOpenerPolicyReporter() method called from RFHI::TakeNewDocumentPropertiesFromNavigation(). - This has the unintended side effect: RFHI::CreateNewWindow() also calls SetCrossOriginOpenerPolicyReporter on a new rfh instance to inherit the coop reporter on main frame. Unfortunately this overwrites the just initialized coop reporter with the new frame's reporting source, which has no reporting-endpoints configured. - As a result we're not seeing COOP reports from opener document after the document is committed to the new window. - This CL addresses the issue by moving the overwriting logic to RFHI::TakeNewDocumentPropertiesFromNavigation(), where it's called only when we move the coop reporter used in NavigationRequest to RFHI. - Added a new browsertest case that ensures coop reports is successfully uploaded from opener document's coop reporter. (cherry picked from commit 74e1a068995488f6fa3b3d4d12d793a235a9228c) Bug: 1258121 Change-Id: I705e61eecc78a5a2afefaded90dad4223513aeb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256381 Commit-Queue: Rodney Ding <rodneyding@google.com> Reviewed-by: Ian Clelland <iclelland@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#937713} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3298435 Auto-Submit: Rodney Ding <rodneyding@google.com> Owners-Override: Srinivas Sista <srinivassista@chromium.org> Reviewed-by: Srinivas Sista <srinivassista@chromium.org> Cr-Commit-Position: refs/branch-heads/4664@{#1145} Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.