[go: up one dir, main page]

[M96 Merge]Fix coop reporter not inheriting reporting source.

- Previously we overwrite coop reporter's reporting source in the
  RFHI::SetCrossOriginOpenerPolicyReporter() method called from
  RFHI::TakeNewDocumentPropertiesFromNavigation().
- This has the unintended side effect: RFHI::CreateNewWindow()
  also calls SetCrossOriginOpenerPolicyReporter on a new rfh instance
  to inherit the coop reporter on main frame. Unfortunately this
  overwrites the just initialized coop reporter with the new frame's
  reporting source, which has no reporting-endpoints configured.
- As a result we're not seeing COOP reports from opener document after
  the document is committed to the new window.
- This CL addresses the issue by moving the overwriting logic to
  RFHI::TakeNewDocumentPropertiesFromNavigation(), where it's called
  only when we move the coop reporter used in NavigationRequest to RFHI.
- Added a new browsertest case that ensures coop reports is successfully
  uploaded from opener document's coop reporter.

(cherry picked from commit 74e1a068995488f6fa3b3d4d12d793a235a9228c)

Bug: 1258121
Change-Id: I705e61eecc78a5a2afefaded90dad4223513aeb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256381
Commit-Queue: Rodney Ding <rodneyding@google.com>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#937713}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3298435
Auto-Submit: Rodney Ding <rodneyding@google.com>
Owners-Override: Srinivas Sista <srinivassista@chromium.org>
Reviewed-by: Srinivas Sista <srinivassista@chromium.org>
Cr-Commit-Position: refs/branch-heads/4664@{#1145}
Cr-Branched-From: 24dc4ee75e01a29d390d43c9c264372a169273a7-refs/heads/main@{#929512}
2 files changed
tree: d94c95ec6b3f74f8d5ab570cc8e7bcc218a794ce
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.