Publish DEPS for Chromium 36.0.1985.0
Fix names of headers in mojo_public.gypi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269467 0039d316-1c4b-4281-b951-d872f2087c98
Revert 269452 "Fix header name in GYP file"
Reverting along with 269443 since compile errors weren't fixed
> Fix header name in GYP file
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/276043004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269466 0039d316-1c4b-4281-b951-d872f2087c98
Enable hole-punching in Android by default.
This CL also enables the tests for hole-punching.
BUG=329447
R=boliu@chromium.org, qinmin@chromium.org
Review URL: https://codereview.chromium.org/264893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269464 0039d316-1c4b-4281-b951-d872f2087c98
Revert 263741 "Enable surprise me wallpaper for new profiles."
> Enable surprise me wallpaper for new profiles.
>
> BUG=305855, 322603
> TBR=awatson@chromium.org
>
> Review URL: https://codereview.chromium.org/162393002
TBR=harrym@chromium.org
Review URL: https://codereview.chromium.org/274163003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269463 0039d316-1c4b-4281-b951-d872f2087c98
First step towards invalidations componentization
Moves some files from chrome/browser/invalidation to
components/invalidation. The files moved in this CL are those that do
not have dependencies on chrome/, so they can be moved without
significant refactoring.
This refactoring touches a lot of files, but none of the changes are
meaningful. Most of it inovlves changing #include paths, updating DEPS,
changing header guards, and other trivial changes.
One part of this change that is significant is that it creates two new
static libraries and moves some of the symbols formerly defined in
chrome/browser/invalidation into those libraries. There is some risk of
linker errors if this was done wrong.
TBR=bartfab,blundell
BUG=336571
Review URL: https://codereview.chromium.org/255273002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269462 0039d316-1c4b-4281-b951-d872f2087c98
aw: Refactor hardware init
Move inserting the initialization task to first OnDraw with hardware
canvas rather than OnAttach. Also insert view into GLViewRendererManager
here.
Refactor DeferredGpuCommandService into its own file, and have
AwContents interact with it. Move ScopedAppGLStateRestore into
AwContents as well. This meant that the header cannot include any GL
files, so required a refactor there.
Also discovered GLViewRendererManager::PushBack is not thread safe
during refactoring. Fix that as well.
BUG=344087
Review URL: https://codereview.chromium.org/273703008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269461 0039d316-1c4b-4281-b951-d872f2087c98
Add histograms to record document.execCommand.
Add a UMA histogram metrics counting commands when document.execCommand is called.
Each histogram id corresponding to a command name is in EditorCommand.cpp:
https://src.chromium.org/viewvc/blink?revision=165849
The new UMA is WebCore.Document.execCommand and the corresponding implementation is done:
https://src.chromium.org/viewvc/blink?revision=172020&view=revision
This CL rewrites the summary of WebCore.Editing.Commands and let WebCore.Document.execCommand use the original summary because we found that WebCore.Editing.Commands doesn't represent what we want to do as the original summary says.
That's because the new UMA is needed.
BUG=338241
Review URL: https://codereview.chromium.org/278563002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269460 0039d316-1c4b-4281-b951-d872f2087c98
Retain popup bubble mouse status even through updates.
Currently rapid updates completely block the user from
interacting with the view even for completely static
content such as the close button.
BUG=368025
Review URL: https://codereview.chromium.org/271773002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269458 0039d316-1c4b-4281-b951-d872f2087c98
Update .DEPS.git
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269457 0039d316-1c4b-4281-b951-d872f2087c98
Blink roll 173743:173750
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=173743:173750&mode=html
TBR=
BUG=
Review URL: https://codereview.chromium.org/275063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269456 0039d316-1c4b-4281-b951-d872f2087c98
[NaCl SDK] Add memory.h to include/newlib and include/pnacl
BUG=309127
R=binji@chromium.org
Review URL: https://codereview.chromium.org/270743005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269455 0039d316-1c4b-4281-b951-d872f2087c98
Revert 269445 "Auth work to support new auth protocol"
Compile failure on linux.
FAILED: /b/build/goma/gomacc c++ -MMD -MF obj/chrome/browser/extensions/api/cast_channel/browser_extensions.cast_auth_util_nss.o.d -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DCOMPONENT_BUILD -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DFULL_SAFE_BROWSING -DGL_GLEXT_PROTOTYPES -DMOJO_USE_SYSTEM_IMPL -DGTEST_HAS_POSIX_RE=0 -DLIBPEERCONNECTION_LIB=1 -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS=1 -DSK_SUPPORT_LEGACY_GETTOPDEVICE -DSK_SUPPORT_LEGACY_N32_NAME -DSK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE -DSK_SUPPORT_LEGACY_GETTOTALCLIP -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DLINUX -DPOSIX -DU_USING_ICU_NAMESPACE=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_LINUX -DUSE_NSS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -I../.. -Iobj/chrome/browser_extensions.gen -Iobj/chrome/browser_extensions.gen/chrome -I../../third_party/khronos -I../../gpu -I../../skia/config -I../../third_party/WebKit/Source -Igen/protoc_out -I../../third_party/protobuf -I../../third_party/protobuf/src -Igen/chrome -Igen -I../../third_party/re2 -Igen/components/strings -I../../third_party/WebKit -I../../net/third_party/nss/ssl -Igen/extensions/strings -I../../third_party/skia/src/core -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source -I../../testing/gtest/include -I../../third_party -I../../third_party/webrtc -I../../third_party/cacheinvalidation/overrides -I../../third_party/cacheinvalidation/src -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/leveldatabase/src/include -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase -Igen/ui/app_locale_settings -Igen/ui/ui_strings -Igen/ui/ui_resources -Igen/webkit -Igen/ui/keyboard -Igen/policy -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -pthread -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/nss -I/usr/include/nspr -I/usr/include/dbus-1.0 -I/usr/lib/i386-linux-gnu/dbus-1.0/include -msse2 -mfpmath=sse -mmmx -m32 -O0 -g -funwind-tables -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -c ../../chrome/browser/extensions/api/cast_channel/cast_auth_util_nss.cc -o obj/chrome/browser/extensions/api/cast_channel/browser_extensions.cast_auth_util_nss.o
../../chrome/browser/extensions/api/cast_channel/cast_auth_util_nss.cc: In function 'bool {anonymous}::VerifyCredentials(const extensions::api::cast_channel::AuthResponse&, const string&)':
../../chrome/browser/extensions/api/cast_channel/cast_auth_util_nss.cc:263:60: error: invalid conversion from 'const SECItem* {aka const SECItemStr*}' to 'SECItem* {aka SECItemStr*}' [-fpermissive]
/usr/include/nss/keyhi.h:215:1: error: initializing argument 1 of 'SECKEYPublicKey* SECKEY_ImportDERPublicKey(SECItem*, CK_KEY_TYPE)' [-fpermissive]
ninja: build stopped: subcommand failed.
> Auth work to support new auth protocol
>
> BUG=345759
>
> Review URL: https://codereview.chromium.org/254083007
TBR=munjal@chromium.org
Review URL: https://codereview.chromium.org/273123003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269454 0039d316-1c4b-4281-b951-d872f2087c98
Whitelist experimental bookmarks extensions for fileSystem APIs
These APIs are used to enable bookmarks export functionality.
BUG=312900,319444,371562,372039
R=kalman@chromium.org
Review URL: https://codereview.chromium.org/275193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269453 0039d316-1c4b-4281-b951-d872f2087c98
Fix header name in GYP file
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269452 0039d316-1c4b-4281-b951-d872f2087c98
Make ContentViewRenderView::CompositeToBitmap not CompositeAndReadback.
The CompositeAndReadback is going away, and this method is thought to
be unused. Make the method just fail and return false.
R=aelias, tedchoc@chromium.org
BUG=371592
Review URL: https://codereview.chromium.org/270933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269448 0039d316-1c4b-4281-b951-d872f2087c98
Adds getter for ContextFactory to content
Chrome (and others) need this so they can supply the ContextFactory to
the Compositor and get rid of Compositor::GetInstance.
BUG=none
TEST=none
R=piman@chromium.org
Review URL: https://codereview.chromium.org/276973002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269447 0039d316-1c4b-4281-b951-d872f2087c98
[OriginChip] Add an option to display only on search result pages.
BUG=370095
Review URL: https://codereview.chromium.org/266263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269446 0039d316-1c4b-4281-b951-d872f2087c98
Auth work to support new auth protocol
BUG=345759
Review URL: https://codereview.chromium.org/254083007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269445 0039d316-1c4b-4281-b951-d872f2087c98
Enables using the magnification API for screen capturing on Windows under a Finch experiment.
NOTRY=true
NOTREECHECKS=true
BUG=https://code.google.com/p/webrtc/issues/detail?id=2789
Review URL: https://codereview.chromium.org/268123003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269444 0039d316-1c4b-4281-b951-d872f2087c98
Mojo: Replace RemotePtr with InterfacePtr and InterfaceImpl
Interfaces no longer have explicit Peer attributes. An interface may now optionally have a Client interface, in which case a SetClient method will be auto-generated.
InterfacePtr is a proxy to a remote instance of an interface. InterfaceImpl is a base class used when implementing an interface. Both have facilities for binding to a pipe, etc. An InterfacePtr is movable but not copyable and looks a lot like RemotePtr save for how it gets initialized (via the Bind method now).
I've added some new top-level functions:
MakeProxy - makes it easy to initialize an InterfacePtr in say a member initializer list.
BindToPipe - this is how you bind an InterfaceImpl to a pipe. once bound, they cannot be unbound until the object is destroyed or the pipe is closed.
BindToProxy - builds on top of BindToPipe, however, it hides the details of the pipe. What you get back is an InterfacePtr.
Generated C++ code now passes InterfacePtr instead of InterfaceHandle. As a result, we have far less need for typed subclasses of MessagePipeHandle, so I eliminated them. The code that needs to deal with raw handles generally has to deal with {Scoped}MessagePipeHandle, and adding strong typing to these handles doesn't seem helpful anymore.
R=davemoore@chromium.org
Review URL: https://codereview.chromium.org/265793015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269443 0039d316-1c4b-4281-b951-d872f2087c98
Refactor BPFTesterCompatibilityDelegate to use AuxHolder instead
Review URL: https://codereview.chromium.org/271943002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269442 0039d316-1c4b-4281-b951-d872f2087c98
Whitelist additional experimental extension for bookmarkManagerPrivate API
BUG=371562
Review URL: https://codereview.chromium.org/270783006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269441 0039d316-1c4b-4281-b951-d872f2087c98
Fix webview tag's documentation to specify correct ClearDataTypeSet for clearData API.
BUG=371488
NOTRY=true
Test=The preview link for this patch is:
https://chrome-apps-doc.appspot.com/_patch/271913003/apps/tags/webview#type-ClearDataTypeSet
Once the change is committed, this can be viewed in
https://developer.chrome.com/apps/tags/webview#type-ClearDataTypeSet
You should see only 6 items listed as types:
appcache/cookies/fileSystems/indexedDB/localStorage/webSQL
And it should not list unsupported items such as "downloads", "pluginData", ... which it does without this change.
Review URL: https://codereview.chromium.org/271913003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269440 0039d316-1c4b-4281-b951-d872f2087c98
[GCM] Add more UMA to GCM
Also fix a bug that the default TTL value is set to 0.
BUG=361374,371149
TEST=new test added for default TTL bug
Review URL: https://codereview.chromium.org/270783002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269439 0039d316-1c4b-4281-b951-d872f2087c98
Revert 269415 "Introduce a new framework for back-and-forth trac..."
Reverting because this appears to have caused Linux TSAN redness.
> Introduce a new framework for back-and-forth tracked preference migration
> between Protected Preferences and unprotected Preferences.
>
> Migration from unprotected Preferences to Protected Preferences was previously
> done after both stores had been initialized. This was inherently incorrect as
> some operations (PrefHashFilter::FilterOnLoad) would occur before the values
> had been moved to the proper store. It also introduced a weird method in
> PrefHashFilter::MigrateValues which required an independent PrefHashFilter
> (backed by a copy of the real PrefHashStore). This after-the-fact migration
> caused Settings.TrackedPreferenceCleared spikes when changing a value from
> being enforced to not being enforced (as we'd have a MAC, but no value yet in
> this store when running FilterOnLoad()) and more importantly it also caused
> issue 365769 -- both of these issues highlight the incorrectness of the
> current approach.
>
> The migration back from Protected Preferences to unprotected Preferences when
> enforcement was disabled was using yet another mechanism which would only kick
> in when a given pref was written to (ref. old non-const
> SegregatedPrefStore::StoreForKey()).
>
> The new framework intercepts PrefFilter::FilterOnLoad() events for both stores
> and does the back-and-forth migration in place before it even hands them back
> to the PrefFilter::FinalizeFilterOnLoad() which then hands it back to the
> JsonPrefStores (so that they are agnostic to the migration; from their point
> of view their values were always in their store as they received it).
> Furthermore, this new framework will easily allow us to later move MACs out of
> Local State into their respective stores (which is a task on our radar which
> we currently have no easy way to accomplish).
>
> The new framework also handles read errors better. For example, it was
> previously possible for the unprotected->protected migration to result in data
> loss if the protected store was somehow read-only from a read error while the
> unprotected store wasn't -- resulting in an in-memory migration only flushed
> to disk in the store from which the value was deleted... The new framework
> handles those cases, preferring temporary data duplication over potential data
> loss (duplicated data is cleaned up once confirmation is obtained that the new
> authority for this data has been successfully written to disk -- it will even
> try again in following Chrome runs if it doesn't succeed in this one).
>
> Note: This CL helped LSAN discover an existing leak in post_task_and_reply_impl.cc, see issue 371974 for details.
>
> BUG=365769, 371974
> TEST=
> A) Make sure all kTrackedPrefs consistently report
> Settings.TrackedPreferenceUnchanged across changes from various enforcement
> levels (using --force-fieldtrials).
> B) Make sure the prefs are properly migrated to their new store (and
> subsequently cleaned up from their old store) when changing the
> enforcement_level across multiple runs.
> C) Make sure prefs are properly migrated in a quick startup/shutdown with a
> new enforcement_level and that their old value is properly cleaned up in a
> subsequent startup at the same enforcement_level (or re-migrated at another
> enforcement_level).
>
> R=bauerb@chromium.org, robertshield@chromium.org, stuartmorgan@chromium.org, thakis@chromium.org
>
> Initially Committed in: https://src.chromium.org/viewvc/chrome?view=rev&revision=269346
> Reverted in: https://src.chromium.org/viewvc/chrome?view=rev&revision=269367
>
> Review URL: https://codereview.chromium.org/257003007
TBR=gab@chromium.org
Review URL: https://codereview.chromium.org/273243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269438 0039d316-1c4b-4281-b951-d872f2087c98
Fix instructions to generate .DEPS.git
Adds the -w argument in the instructions in DEPS.
See chromium-dev thread http://goo.gl/sVP94W.
BUG=
NOTRY=true
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/279583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269435 0039d316-1c4b-4281-b951-d872f2087c98
Domain Reliability: More security review.
Change some trivial stuff so sleevi can do more security review.
Also, add rdsmith as an OWNER.
BUG=356791
Review URL: https://codereview.chromium.org/252613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269434 0039d316-1c4b-4281-b951-d872f2087c98
Add empty Linux implementation of audio_service.
BUG=371501
Review URL: https://codereview.chromium.org/276733003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269433 0039d316-1c4b-4281-b951-d872f2087c98
Reland another small part of r267947. Second attempt.
This just contains only the download_to_file chuck from r267947 which is
unlikely to break any layout tests, existing unit tests or chrome production
code.
Tests ran: both content_shell and content_unittests
BUG=265753, 338338, 237249
R=jam@chromium.org
Review URL: https://codereview.chromium.org/274473003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269432 0039d316-1c4b-4281-b951-d872f2087c98
Optimize png files in ui/resources, ash/resources
$ optimize-png-files.sh -o2 -r260319 ui/resources/ ash/resources/
Processed 14 files (out of 90 files) in 00:06:34s
Result : 14264 => 12870 bytes (1394 bytes : 9 %)
BUG=372036
TBR=msw@chromium.org
Review URL: https://codereview.chromium.org/277103002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269431 0039d316-1c4b-4281-b951-d872f2087c98
Missing OS guard before including android header.
An Android header was unconditionally included. It works as long as the
header doesn't use any Android specific code but it's doomed to
break something eventually.
BUG=None
Review URL: https://codereview.chromium.org/267323008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269430 0039d316-1c4b-4281-b951-d872f2087c98
Add back the ALERT trick to detect screen readers.
This fires an EVENT_OBJECT_ALERT notification on the legacy hwnd
with a custom id, and if we get a response we enable full web
accessibility.
This code used to be in render_widget_host_view_win. The replacement
code was not working reliably for unknown reasons, and other accessibility
clients were relying on the previous trick - see bugs.
BUG=319523,342319
NOTRY=true
R=ananta@chromium.org, creis@chromium.org
Review URL: https://codereview.chromium.org/272803003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269429 0039d316-1c4b-4281-b951-d872f2087c98
Fix crash and off-by-one error in MMX YUVA->ARGB conversion.
BUG=370520
TEST=YUVConvertTest.YUVAtoARGB_MMX_MatchReference
Review URL: https://codereview.chromium.org/271443006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269428 0039d316-1c4b-4281-b951-d872f2087c98
clang: Instead of having update.sh clobber out/, add a define with the current revision.
When clang is turned on or off, or when clang is updated, all .o files and all
precompiled headers need to be rebuilt. This is currently done by having the
update script remove the out/ directory. This has issues:
* It fails to catch build directories with different names (e.g. out_android)
* It removes other build artifacts (like resources) that don't need rebuilding
* It doesn't happen when turning clang off (i.e. moving clang -> gcc).
Instead, let common.gypi add a define with the current clang revision to each
source file. This way, the clang revision is on each compile's command line
and the build system's commandline tracking can take care of the rebuilding.
BUG=nativeclient:3840
NOTRY=true
Review URL: https://codereview.chromium.org/268363020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269427 0039d316-1c4b-4281-b951-d872f2087c98
Changes to deletion/ownership of nodes in the client lib.
Nodes are now owned by the view manager. Constructors/destructors moved to private/protected. The ViewManager now maintains a map of id->node.
Adds an observer method for destruction. Clients will need to implement this to invalidate their pointer (perhaps I should invent a node smart ptr).
Adds lib tests for node removal, destruction, and connection destruction (when a connection is destroyed, all nodes it created should be destroyed).
Adds a client notification from the service to notify other clients of node destruction & some tests.
R=sky@chromium.org
http://crbug.com/365012
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269414
Review URL: https://codereview.chromium.org/274733004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269426 0039d316-1c4b-4281-b951-d872f2087c98
Always display the origin chip, even if it won't fit.
BUG=369853
R=shess@chromium.org
Review URL: https://codereview.chromium.org/273883002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269425 0039d316-1c4b-4281-b951-d872f2087c98
Revert 269414 "Changes to deletion/ownership of nodes in the cli..."
> Changes to deletion/ownership of nodes in the client lib.
>
> Nodes are now owned by the view manager. Constructors/destructors moved to private/protected. The ViewManager now maintains a map of id->node.
> Adds an observer method for destruction. Clients will need to implement this to invalidate their pointer (perhaps I should invent a node smart ptr).
> Adds lib tests for node removal, destruction, and connection destruction (when a connection is destroyed, all nodes it created should be destroyed).
> Adds a client notification from the service to notify other clients of node destruction & some tests.
>
> R=sky@chromium.org
> http://crbug.com/365012
>
> Review URL: https://codereview.chromium.org/274733004
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/280023002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269421 0039d316-1c4b-4281-b951-d872f2087c98
webstorePrivate: Support an |authuser| property in beginInstallWithManifest3.
This adds support for an optional |authuser| integer property
in the |details| object passed to beginInstallWithManifest3.
This value is propagated down to the WebstoreInstaller and used
to augment the CRX download request with a standard-ish
|authuser| query parameter corresponding to the index of the
installing user within a multi-login session.
BUG=371100
R=asargent@chromium.org
Review URL: https://codereview.chromium.org/270793002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269420 0039d316-1c4b-4281-b951-d872f2087c98
Ensure that _GNU_SOURCE is defined early enough
This style cleanup broke some versions of glibc that include fcntl.h from
another header before it is explicitly included:
https://codereview.chromium.org/236083002/
We need _GNU_SOURCE defined before the first time fcntl.h is included since
we use the linux-specific O_DIRECTORY extension.
Thanks to johan_e@opera.com for helping track this down.
NOTRY=true
Review URL: https://codereview.chromium.org/266913019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269419 0039d316-1c4b-4281-b951-d872f2087c98
Test that OmniboxViewViews has opaque background.
To make subtle regressions where subpixel rendering isn't
used on Chrome OS less likely, add an OmniboxViewViews
browsertest that checks that the omnibox text isn't rendered
onto a transparent background.
Also remove an outdated reference to GTK and fix a style
issue in LocationBarView.
BUG=none
Review URL: https://codereview.chromium.org/262093014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269418 0039d316-1c4b-4281-b951-d872f2087c98
Reland r264914
This was accidentally reverted in r267753
Original description:
Use VAO for default_vertex_attrib_manager if available.
By using VAO's we can make virtual context switches faster
by a single glBindVertexArrayOES instead of restoring all
attributes one-by-one.
BUG=
TBR=vmiura
NOTRY=true
Review URL: https://codereview.chromium.org/278653002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269417 0039d316-1c4b-4281-b951-d872f2087c98
Update a function parameter's name in the comment for FillClientHello.
Merge internal CL: 66548143
R=rtenneti@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/277523008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269416 0039d316-1c4b-4281-b951-d872f2087c98
Introduce a new framework for back-and-forth tracked preference migration
between Protected Preferences and unprotected Preferences.
Migration from unprotected Preferences to Protected Preferences was previously
done after both stores had been initialized. This was inherently incorrect as
some operations (PrefHashFilter::FilterOnLoad) would occur before the values
had been moved to the proper store. It also introduced a weird method in
PrefHashFilter::MigrateValues which required an independent PrefHashFilter
(backed by a copy of the real PrefHashStore). This after-the-fact migration
caused Settings.TrackedPreferenceCleared spikes when changing a value from
being enforced to not being enforced (as we'd have a MAC, but no value yet in
this store when running FilterOnLoad()) and more importantly it also caused
issue 365769 -- both of these issues highlight the incorrectness of the
current approach.
The migration back from Protected Preferences to unprotected Preferences when
enforcement was disabled was using yet another mechanism which would only kick
in when a given pref was written to (ref. old non-const
SegregatedPrefStore::StoreForKey()).
The new framework intercepts PrefFilter::FilterOnLoad() events for both stores
and does the back-and-forth migration in place before it even hands them back
to the PrefFilter::FinalizeFilterOnLoad() which then hands it back to the
JsonPrefStores (so that they are agnostic to the migration; from their point
of view their values were always in their store as they received it).
Furthermore, this new framework will easily allow us to later move MACs out of
Local State into their respective stores (which is a task on our radar which
we currently have no easy way to accomplish).
The new framework also handles read errors better. For example, it was
previously possible for the unprotected->protected migration to result in data
loss if the protected store was somehow read-only from a read error while the
unprotected store wasn't -- resulting in an in-memory migration only flushed
to disk in the store from which the value was deleted... The new framework
handles those cases, preferring temporary data duplication over potential data
loss (duplicated data is cleaned up once confirmation is obtained that the new
authority for this data has been successfully written to disk -- it will even
try again in following Chrome runs if it doesn't succeed in this one).
Note: This CL helped LSAN discover an existing leak in post_task_and_reply_impl.cc, see issue 371974 for details.
BUG=365769, 371974
TEST=
A) Make sure all kTrackedPrefs consistently report
Settings.TrackedPreferenceUnchanged across changes from various enforcement
levels (using --force-fieldtrials).
B) Make sure the prefs are properly migrated to their new store (and
subsequently cleaned up from their old store) when changing the
enforcement_level across multiple runs.
C) Make sure prefs are properly migrated in a quick startup/shutdown with a
new enforcement_level and that their old value is properly cleaned up in a
subsequent startup at the same enforcement_level (or re-migrated at another
enforcement_level).
R=bauerb@chromium.org, robertshield@chromium.org, stuartmorgan@chromium.org, thakis@chromium.org
Initially Committed in: https://src.chromium.org/viewvc/chrome?view=rev&revision=269346
Reverted in: https://src.chromium.org/viewvc/chrome?view=rev&revision=269367
Review URL: https://codereview.chromium.org/257003007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269415 0039d316-1c4b-4281-b951-d872f2087c98
Changes to deletion/ownership of nodes in the client lib.
Nodes are now owned by the view manager. Constructors/destructors moved to private/protected. The ViewManager now maintains a map of id->node.
Adds an observer method for destruction. Clients will need to implement this to invalidate their pointer (perhaps I should invent a node smart ptr).
Adds lib tests for node removal, destruction, and connection destruction (when a connection is destroyed, all nodes it created should be destroyed).
Adds a client notification from the service to notify other clients of node destruction & some tests.
R=sky@chromium.org
http://crbug.com/365012
Review URL: https://codereview.chromium.org/274733004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269414 0039d316-1c4b-4281-b951-d872f2087c98
Initialize ICU on remoting_native_messaging_host
BUG=371432
R=rmsousa@chromium.org
Review URL: https://codereview.chromium.org/274933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269413 0039d316-1c4b-4281-b951-d872f2087c98
Mojo: (Theoretically) implement sending PlatformHandles (i.e., FDs) across a RawChannel on POSIX.
The read side isn't implemented yet, so I can't test it yet.
R=yzshen@chromium.org
Review URL: https://codereview.chromium.org/279613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269412 0039d316-1c4b-4281-b951-d872f2087c98
Load Easy Unlock only in user sessions.
BUG=371502
Review URL: https://codereview.chromium.org/271963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269411 0039d316-1c4b-4281-b951-d872f2087c98
Added mac_gpu to the default set of try servers.
mac_gpu is already experimentally receiving a percentage of the
Chromium and Blink CQs' load, and the hardware has just been fully
built out. Expand its testing to cover manually submitted try jobs.
BUG=327170
R=phajdan.jr@chromium.org,maruel@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/269313009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269410 0039d316-1c4b-4281-b951-d872f2087c98
Handle SYN_DROPPED and SYN_MT_REPORT in ozone/evedev
SYN_DROPPED drops all events until after the next SYN_REPORT.
SYN_MT_REPORT is used with type A devices instead of ABS_MT_SLOT.
BUG=359742
TEST=new unittests
Review URL: https://codereview.chromium.org/273523010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269409 0039d316-1c4b-4281-b951-d872f2087c98
Always wipe device data, but dont reboot.
We keep seeing the INSTALL_FAILED_INSUFFICIENT_STORAGE error on the devices. The
APK we install to check for this failure succeeds even when this error exists on
the device (presumably because the APK we install is too small). Thus, this CL
will always wipe the device. It removes the reboot, because that would make the
step take too long.
BUG=335549
TBR=yfriedman@chromium.org
Review URL: https://codereview.chromium.org/255783008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269408 0039d316-1c4b-4281-b951-d872f2087c98
Fix psutil usage in Chromoting Linux Me2Me script.
This code was failing in Ubuntu Trusty because psutil is at version
1.2.1, but the previous code was incorrectly detecting it as a "new"
2.0+ API. Fixed the check to be more explicit.
Also, this bypasses the issue of psutil.Error not being defined in
older versions by explicitly trapping the individual exception types
instead of psutil.Error. Note that psutil.error was always a private
API and should never have been used in the first place.
TEST=Works in Ubuntu Precise and Trusty
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/272543006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269407 0039d316-1c4b-4281-b951-d872f2087c98
Fix leak in WidgetTest.EventHandlersOnRootView from r269286
Use a scoped_ptr to prevent the memory leak since |view|
is detached from the views hierarchy halfway through
the test.
See http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/1237/steps/views_unittests/logs/stdio
BUG=none
R=sadrul@chromium.org
Review URL: https://codereview.chromium.org/277023002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269406 0039d316-1c4b-4281-b951-d872f2087c98
Restore base::ThreadRestrictions::ScopedAllowIO to see if it fixes linux bot failures.
BUG=61827
NOTRY=true
NOTREECHECKS=true
R=asanka@chromium.org
Review URL: https://codereview.chromium.org/274193004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269405 0039d316-1c4b-4281-b951-d872f2087c98
Implement stats reporting in Android client
This reports the same connection statistics and session change events
that are currently reported by the web-app.
Caveats:
This does not provide Chrome or Webapp versions - instead it
reports the Android OS version, and the app version, under
differently-named keys.
Session termination events don't seem to be reported. This is a
limitation of the Android client that might not be easy to work around.
BUG=368015
R=rmsousa@chromium.org
Review URL: https://codereview.chromium.org/270613005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269404 0039d316-1c4b-4281-b951-d872f2087c98
Add link https://support.google.com/chrome/answer/96817 to the checkbox text of the session crashed bubble.
BUG=293702
Review URL: https://codereview.chromium.org/266193013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269403 0039d316-1c4b-4281-b951-d872f2087c98
Close omnibox popup when user drags the location URL icon or text in the omnibox. The user may have wanted to drag it to something is was covered by the omnibox popup.
BUG=356887
Review URL: https://codereview.chromium.org/251373004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269402 0039d316-1c4b-4281-b951-d872f2087c98
Add mojo tests to standard tests that are run on testers on the main waterfall.
BUG=
Review URL: https://codereview.chromium.org/268353008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269401 0039d316-1c4b-4281-b951-d872f2087c98
Make erg@ an OWNER for x11 unittests too.
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/270893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269400 0039d316-1c4b-4281-b951-d872f2087c98
Allow updating of offscreen notifications
A call to notifications.update() may raise priority from <0 to >=0,
which should cause a notification to toast.
BUG=353405
R=dewittj@chromium.org, rsesek@chromium.org
Review URL: https://codereview.chromium.org/268653003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269399 0039d316-1c4b-4281-b951-d872f2087c98
suppress errors from content_browsertests to be investigated
TBR=bruening@chromium.org
BUG=371357, 371942, 371946, 371950, 371959
Review URL: https://codereview.chromium.org/275203002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269398 0039d316-1c4b-4281-b951-d872f2087c98
Implement core of compliant MediaSource coded frame processing
Introduces FrameProcessor and associated unit tests that implement the
core of the Coded Frame Processing algorithm in the current Media Source
Extension spec (April 1, 2014 MSE editor's draft).
R=acolwell@chromium.org
BUG=249422
TEST=All media_unittests pass and no http/tests/media/media-source layout tests regress locally on Linux with proprietary codecs enabled
Review URL: https://codereview.chromium.org/180153003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269397 0039d316-1c4b-4281-b951-d872f2087c98
Use the DefaultSearchManager as the exclusive authority on DSE, ignoring Web Data.
BUG=365762
R=engedy@chromium.org, jochen@chromium.org, pkasting@chromium.org, zea@chromium.org
Review URL: https://codereview.chromium.org/268643002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269396 0039d316-1c4b-4281-b951-d872f2087c98
Revert 269340 "Support multiple sign-in for extension updates."
> Support multiple sign-in for extension updates.
>
> This changes the ExtensionDownloader to attempt multiple
> sequentual queries for CRX downloads, iterating over incremental
> values for the authuser query parameter (up to a max of 10).
>
> BUG=370964
> R=asargent@chromium.org
>
> Review URL: https://codereview.chromium.org/279453002
TBR=rockot@chromium.org
Review URL: https://codereview.chromium.org/275233002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269393 0039d316-1c4b-4281-b951-d872f2087c98
Revert 269354 "Added automatic mode to FakeInputAudioStream to g..."
This CL caused the MediaAccessAPIDeny_TestDenyWithPreventDefault to fail on the mac builders.
The same test also failed in the mac chromium rel browser tests try runs. Sadly they showed up
as green.
Please fix and reland
> Added automatic mode to FakeInputAudioStream to generate automatic beeps.
>
> This patch is to allow writing audio only tests using the fake input stream, also it changes the name of the fake device from "Default" to "Fake Audio, which I hope it will make things less confusing.
>
> TBR=dalecurtis@chromium.org
> NOTRY=true
>
> BUG=358541
> TEST=bots existing webrtc tests.
>
> Review URL: https://codereview.chromium.org/272723006
TBR=xians@chromium.org
Review URL: https://codereview.chromium.org/273163002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269391 0039d316-1c4b-4281-b951-d872f2087c98
Revert 269343 "Unload all apps / extensions immediately when del..."
Tentatively reverting to see if it fixes the browser_tests ShutdownStartupCycle failure.
> Unload all apps / extensions immediately when deleting a profile.
>
> Previously apps could remain running with references to profiles that had been deleted by users, but before the browser shut down and profiles were fully removed. Problems included E.g. opening a link in an app would open a tab in the deleted profile.
>
> BUG=368684
> TEST=Manual testing as described on http://crbug.com/368684#c1
>
> Review URL: https://codereview.chromium.org/266343002
TBR=scheib@chromium.org
Review URL: https://codereview.chromium.org/278093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269383 0039d316-1c4b-4281-b951-d872f2087c98
Add UMA stats for appearance settings
BUG=370591
R=dbeam@chromium.org, asvitkine@chromium.org
Review URL: https://codereview.chromium.org/273813002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269381 0039d316-1c4b-4281-b951-d872f2087c98
Add UMA stat for language and input settings
"Options_LanuageAndSpellCheckSettings"[sic] is being recorded as an action when
the language and input settings overlay is opened from the main settings page,
but the action doesn't actually exist.
BUG=335646
R=dbeam@chromium.org
TBR=asvitkine@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/277583003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269380 0039d316-1c4b-4281-b951-d872f2087c98
This bug arose when setting the event as handled did not prevent window activation on overview mode.
BUG=370209
TEST=FocusControllerMouseEventTest.IgnoreHandledEvent
R=sky@chromium.org, tdanderson@chromium.org
Review URL: https://codereview.chromium.org/264053003
Patch from Nicolas Satragno <nsatragno@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269379 0039d316-1c4b-4281-b951-d872f2087c98
Animate the OverviewButtonTray
Take the animations from TrayItemView and port them to TrayBackgroundView
so that the outer trays also animate their visibility.
TEST=OverviewButtonTray
TEST=SystemTrayTest
TEST=WebNotificationTrayTest
BUG=363714
Review URL: https://codereview.chromium.org/251193004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269378 0039d316-1c4b-4281-b951-d872f2087c98
Update Play Store what's-new text for Chromoting app.
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/275703002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269377 0039d316-1c4b-4281-b951-d872f2087c98
Revert 269371 "Move touch CTM from X into Chrome"
Failed compile on Linux Builder
http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29%2832%29/builds/23859/steps/compile/logs/stdio
FAILED: /b/build/goma/gomacc c++ -Wl,-z,now -Wl,-z,relro -Wl,--fatal-warnings -pthread -Wl,-z,noexecstack -fPIC -m32 -Wl,--no-as-needed -Wl,-rpath=\$ORIGIN/lib/ -Wl,-rpath-link=lib/ -o cast_unittests -Wl,--start-group obj/media/base/cast_unittests.run_all_unittests.o obj/media/cast/audio_receiver/cast_unittests.audio_decoder_unittest.o obj/media/cast/audio_receiver/cast_unittests.audio_receiver_unittest.o obj/media/cast/audio_sender/cast_unittests.audio_encoder_unittest.o obj/media/cast/audio_sender/cast_unittests.audio_sender_unittest.o obj/media/cast/congestion_control/cast_unittests.congestion_control_unittest.o obj/media/cast/framer/cast_unittests.cast_message_builder_unittest.o obj/media/cast/framer/cast_unittests.frame_buffer_unittest.o obj/media/cast/framer/cast_unittests.framer_unittest.o obj/media/cast/logging/cast_unittests.encoding_event_subscriber_unittest.o obj/media/cast/logging/cast_unittests.serialize_deserialize_test.o obj/media/cast/logging/cast_unittests.logging_impl_unittest.o obj/media/cast/logging/cast_unittests.logging_raw_unittest.o obj/media/cast/logging/cast_unittests.receiver_time_offset_estimator_impl_unittest.o obj/media/cast/logging/cast_unittests.simple_event_subscriber_unittest.o obj/media/cast/logging/cast_unittests.stats_event_subscriber_unittest.o obj/media/cast/rtcp/cast_unittests.mock_rtcp_receiver_feedback.o obj/media/cast/rtcp/cast_unittests.mock_rtcp_sender_feedback.o obj/media/cast/rtcp/cast_unittests.rtcp_receiver_unittest.o obj/media/cast/rtcp/cast_unittests.rtcp_sender_unittest.o obj/media/cast/rtcp/cast_unittests.rtcp_unittest.o obj/media/cast/rtcp/cast_unittests.receiver_rtcp_event_subscriber_unittest.o obj/media/cast/rtcp/cast_unittests.sender_rtcp_event_subscriber_unittest.o obj/media/cast/rtcp/cast_unittests.test_rtcp_packet_builder.o obj/media/cast/rtp_receiver/cast_unittests.mock_rtp_payload_feedback.o obj/media/cast/rtp_receiver/cast_unittests.receiver_stats_unittest.o obj/media/cast/rtp_receiver/rtp_parser/test/cast_unittests.rtp_packet_builder.o obj/media/cast/rtp_receiver/rtp_parser/cast_unittests.rtp_parser_unittest.o obj/media/cast/test/cast_unittests.end2end_unittest.o obj/media/cast/test/cast_unittests.fake_receiver_time_offset_estimator.o obj/media/cast/test/cast_unittests.fake_single_thread_task_runner.o obj/media/cast/test/cast_unittests.fake_video_encode_accelerator.o obj/media/cast/test/utility/cast_unittests.audio_utility_unittest.o obj/media/cast/test/utility/cast_unittests.barcode_unittest.o obj/media/cast/transport/cast_unittests.cast_transport_sender_impl_unittest.o obj/media/cast/transport/pacing/cast_unittests.mock_paced_packet_sender.o obj/media/cast/transport/pacing/cast_unittests.paced_sender_unittest.o obj/media/cast/transport/rtp_sender/packet_storage/cast_unittests.packet_storage_unittest.o obj/media/cast/transport/rtp_sender/rtp_packetizer/cast_unittests.rtp_packetizer_unittest.o obj/media/cast/transport/rtp_sender/rtp_packetizer/test/cast_unittests.rtp_header_parser.o obj/media/cast/transport/transport/cast_unittests.udp_transport_unittest.o obj/media/cast/video_receiver/cast_unittests.video_decoder_unittest.o obj/media/cast/video_receiver/cast_unittests.video_receiver_unittest.o obj/media/cast/video_sender/cast_unittests.external_video_encoder_unittest.o obj/media/cast/video_sender/cast_unittests.video_encoder_impl_unittest.o obj/media/cast/video_sender/cast_unittests.video_sender_unittest.o obj/media/cast/libcast_base.a obj/media/cast/libcast_receiver.a obj/media/cast/libcast_rtcp.a obj/media/cast/libcast_sender.a obj/media/cast/libcast_test_utility.a obj/media/cast/libcast_transport.a obj/base/libtest_support_base.a obj/testing/libgmock.a obj/testing/libgtest.a obj/media/cast/libcast_logging_proto.a obj/third_party/opus/libopus.a obj/third_party/libvpx/libvpx.a obj/third_party/libvpx/libvpx_asm_offsets_vp8.a obj/third_party/libvpx/libvpx_intrinsics_mmx.a obj/third_party/libvpx/libvpx_intrinsics_sse2.a obj/third_party/libvpx/libvpx_intrinsics_ssse3.a libyuv.a obj/third_party/libjpeg_turbo/libjpeg_turbo.a obj/base/libbase_static.a obj/third_party/libxml/libxml2.a obj/third_party/zlib/libchrome_zlib.a obj/base/third_party/dynamic_annotations/libdynamic_annotations.a lib/libicuuc.so lib/libnet.so lib/libbase.so lib/libgfx_geometry.so lib/libprotobuf_lite.so lib/libshared_memory_support.so lib/libmedia.so lib/libbase_i18n.so lib/libcrcrypto.so -Wl,--end-group -lrt -ldl -lasound
lib//libevents_base.so: undefined reference to `ui::PlatformEventSource::RemovePlatformEventObserver(ui::PlatformEventObserver*)'
lib//libevents_base.so: undefined reference to `ui::PlatformEventSource::GetInstance()'
lib//libevents_base.so: undefined reference to `ui::PlatformEventSource::AddPlatformEventObserver(ui::PlatformEventObserver*)'
collect2: ld returned 1 exit status
ninja: build stopped: subcommand failed.
> Move touch CTM from X into Chrome
>
> Currently we compute the touch CTM in OutputConfigurator
> and push that into X. This CL makes computing the touch CTM
> in DisplayController, and pushing it
> into WindowTreeHostX11. This moves the functionality of
> touch CTM from X into Chrome.
>
> Basically, when there is output configuration change, we
> compute the TouchCTM for each touch device, and push the
> TouchCTM into the WindowTreeHostX11 that is associated
> with the touchscreen. Then when X events reaching root
> window, we use the CTM to map the events coordinate in
> framebuffer space into the root window's coordinate space.
>
>
> BUG=351019, chrome-os-partner:25788
> TEST=tested on Pixel/Clapper with external touch/non-touch displays
> on both extended/mirror mode. Touch events are correctly mapped to
> chrome window or discarded if it is from blank region from letterboxing/pillarboxing mirror mode.
>
> Review URL: https://codereview.chromium.org/191223007
TBR=miletus@chromium.org
Review URL: https://codereview.chromium.org/276013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269376 0039d316-1c4b-4281-b951-d872f2087c98
Do not check GTK+ dependencies when use_ozone is defined.
glib is not included in ozone platform:
https://codereview.chromium.org/249583003
Therefore, we do not need to check GTK+ dependencies when use_ozone is defined.
BUG=None
Review URL: https://codereview.chromium.org/272743002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269373 0039d316-1c4b-4281-b951-d872f2087c98
Replace VideoRendererImpl's kEnded state with a bool.
This is consistent with how AudioRendererImpl handles firing the ended
callback, which keeps the renderer in the "playing" state but remaining
idle.
BUG=110814
Review URL: https://codereview.chromium.org/272783002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269372 0039d316-1c4b-4281-b951-d872f2087c98
Move touch CTM from X into Chrome
Currently we compute the touch CTM in OutputConfigurator
and push that into X. This CL makes computing the touch CTM
in DisplayController, and pushing it
into WindowTreeHostX11. This moves the functionality of
touch CTM from X into Chrome.
Basically, when there is output configuration change, we
compute the TouchCTM for each touch device, and push the
TouchCTM into the WindowTreeHostX11 that is associated
with the touchscreen. Then when X events reaching root
window, we use the CTM to map the events coordinate in
framebuffer space into the root window's coordinate space.
BUG=351019, chrome-os-partner:25788
TEST=tested on Pixel/Clapper with external touch/non-touch displays
on both extended/mirror mode. Touch events are correctly mapped to
chrome window or discarded if it is from blank region from letterboxing/pillarboxing mirror mode.
Review URL: https://codereview.chromium.org/191223007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269371 0039d316-1c4b-4281-b951-d872f2087c98
Let oshima own a few more image_skia_ files.
It seems image_skia has several utility files like
image_skia_rep, image_skia_source, and image_skia_operations.
Also it has image_skia_unittests.cc as well.
The new pattern will be applied to Mac/iOS stuffs like
image_skia_util_ios*, but that wouldn't be a problem
practically because the comment describes the exceptions.
BUG=None
R=oshima@chromium.org, rsesek@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/274523005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269370 0039d316-1c4b-4281-b951-d872f2087c98
android: Refactor Java-side content readback API
To allow for use of the readback API with ContentViewRenderView, we refactor
the content readback logic into ContentReadbackHandler. Readback is performed
through the browser compositor. The owner of the browser compositor should
implement ContentReadbackProvider to indicate to ContentReadbackHandler that
readback is possible.
android= https://chrome-internal-review.googlesource.com/#/c/162873
BUG=370282
Review URL: https://codereview.chromium.org/272643002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269369 0039d316-1c4b-4281-b951-d872f2087c98
Remove support for audio renderers to disable themselves at run time.
UMA data tells us this code path is rarely hit (~0.01% on stable). It
also complicates a lot of media pipeline/demuxer logic. Replace all of
it with an error callback.
BUG=234708
Review URL: https://codereview.chromium.org/270223002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269368 0039d316-1c4b-4281-b951-d872f2087c98
Revert 269346 "Introduce a new framework for back-and-forth trac..."
Fails JsonPrefStoreTest.RemoveClearsEmptyParent on Linux ASan.
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/2074/steps/base_unittests/logs/RemoveClearsEmptyParent
> Introduce a new framework for back-and-forth tracked preference migration
> between Protected Preferences and unprotected Preferences.
>
> Migration from unprotected Preferences to Protected Preferences was previously
> done after both stores had been initialized. This was inherently incorrect as
> some operations (PrefHashFilter::FilterOnLoad) would occur before the values
> had been moved to the proper store. It also introduced a weird method in
> PrefHashFilter::MigrateValues which required an independent PrefHashFilter
> (backed by a copy of the real PrefHashStore). This after-the-fact migration
> caused Settings.TrackedPreferenceCleared spikes when changing a value from
> being enforced to not being enforced (as we'd have a MAC, but no value yet in
> this store when running FilterOnLoad()) and more importantly it also caused
> issue 365769 -- both of these issues highlight the incorrectness of the
> current approach.
>
> The migration back from Protected Preferences to unprotected Preferences when
> enforcement was disabled was using yet another mechanism which would only kick
> in when a given pref was written to (ref. old non-const
> SegregatedPrefStore::StoreForKey()).
>
> The new framework intercepts PrefFilter::FilterOnLoad() events for both stores
> and does the back-and-forth migration in place before it even hands them back
> to the PrefFilter::FinalizeFilterOnLoad() which then hands it back to the
> JsonPrefStores (so that they are agnostic to the migration; from their point
> of view their values were always in their store as they received it).
> Furthermore, this new framework will easily allow us to later move MACs out of
> Local State into their respective stores (which is a task on our radar which
> we currently have no easy way to accomplish).
>
> The new framework also handles read errors better. For example, it was
> previously possible for the unprotected->protected migration to result in data
> loss if the protected store was somehow read-only from a read error while the
> unprotected store wasn't -- resulting in an in-memory migration only flushed
> to disk in the store from which the value was deleted... The new framework
> handles those cases, preferring temporary data duplication over potential data
> loss (duplicated data is cleaned up once confirmation is obtained that the new
> authority for this data has been successfully written to disk -- it will even
> try again in following Chrome runs if it doesn't succeed in this one).
>
> BUG=365769
> TEST=
> A) Make sure all kTrackedPrefs consistently report
> Settings.TrackedPreferenceUnchanged across changes from various enforcement
> levels (using --force-fieldtrials).
> B) Make sure the prefs are properly migrated to their new store (and
> subsequently cleaned up from their old store) when changing the
> enforcement_level across multiple runs.
> C) Make sure prefs are properly migrated in a quick startup/shutdown with a
> new enforcement_level and that their old value is properly cleaned up in a
> subsequent startup at the same enforcement_level (or re-migrated at another
> enforcement_level).
>
> R=bauerb@chromium.org, stuartmorgan@chromium.org, thakis@chromium.org
>
> Review URL: https://codereview.chromium.org/257003007
TBR=gab@chromium.org
Review URL: https://codereview.chromium.org/279943002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269367 0039d316-1c4b-4281-b951-d872f2087c98
Fix handling of async update of keyboard bounds.
BUG=366512
Review URL: https://codereview.chromium.org/261813005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269365 0039d316-1c4b-4281-b951-d872f2087c98
Add UMA stat for display options
"Options_Display" is being recorded as an action when the
device display settings are opened, but the action doesn't
actually exist.
BUG=357360,335646
R=stevenjb@chromium.org, asvitkine@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/272673004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269364 0039d316-1c4b-4281-b951-d872f2087c98
Return has value, in function returning void.
BUG=N/A
Review URL: https://codereview.chromium.org/264373004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269363 0039d316-1c4b-4281-b951-d872f2087c98
Pepper: Clean up ProgressEvent logic.
This simplifies NexeLoadManager, which is getting pretty big. This also removes
an unused field from ProgressEvent, and adds a convenience function for posting
a task to dispatch a progress event from the main thread, which is often
necessary to ensure that progress events are posted to the DOM after other
state changes.
Review URL: https://codereview.chromium.org/270453004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269362 0039d316-1c4b-4281-b951-d872f2087c98
Fix WebURLLoaderImpl::Context leak if a pending request is canceled.
Now, ResourceDispatcher::CancelPendingRequest will send
ResourceHostMsg_CancelRequest and trigger OnRequestComplete. However,
the request is pending and thus OnRequestComplete will be queued.
There are at least two problems if OnRequestComplete is not called:
1. WebURLLoaderImpl::Context will never be released.
2. request_info->buffer leaks. The buffer holds shared memory handle
(file descriptor). fd leaking may lead to HW video decode failure on
ChromeOS (detail in chrome-os-partner:27911#63)
This issue is similar to issue 328092.
BUG=chrome-os-partner:27911,chromium:369221,chromium:369128
R=jam@chromium.org, mmenke@chromium.org
Review URL: https://codereview.chromium.org/268423002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269361 0039d316-1c4b-4281-b951-d872f2087c98
Move window.setShape to Beta channel.
It has been available in Dev channel for over 7 months and the Security
requirements for shipping landed a few weeks ago. This promotes the feature
to Beta channel with the intent to move to Stable in M37.
BUG=196651
R=scheib@chromium.org
Review URL: https://codereview.chromium.org/274763006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269360 0039d316-1c4b-4281-b951-d872f2087c98
Make safely-roll-deps work with git commit hashes
BUG=skia:1945
Review URL: https://codereview.chromium.org/271733007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269359 0039d316-1c4b-4281-b951-d872f2087c98
Linux: Remove some unused NPAPI code.
Review URL: https://codereview.chromium.org/271753006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269358 0039d316-1c4b-4281-b951-d872f2087c98
Remove periodic reconciliation. This is not needed since the reconcilor
listens to both token service changes and gaia cookie changes.
BUG=359700
Review URL: https://codereview.chromium.org/270733002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269357 0039d316-1c4b-4281-b951-d872f2087c98
Mojo: Add the ability to allocate space for platform handle info in TransportData.
We don't really need this for POSIX, but we'll need it for Windows, so
all the interfaces will need to take it into account. E.g., if the
source process can duplicate handles into the target, it needs space to
store the new handle value. (If we're using a broker, other data is
needed.)
R=yzshen@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269197
Review URL: https://codereview.chromium.org/278513003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269356 0039d316-1c4b-4281-b951-d872f2087c98
Add MEDIA_EXPORT to an ffmpeg_common function to link cast_sender_app.
This is needed for the linker to resolve a reference to
media::ChannelLayoutToChromeChannelLayout(), called in
src/media/cast/test/sender.cc (cast_sender_app target).
Review URL: https://codereview.chromium.org/270813002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269355 0039d316-1c4b-4281-b951-d872f2087c98
Added automatic mode to FakeInputAudioStream to generate automatic beeps.
This patch is to allow writing audio only tests using the fake input stream, also it changes the name of the fake device from "Default" to "Fake Audio, which I hope it will make things less confusing.
TBR=dalecurtis@chromium.org
NOTRY=true
BUG=358541
TEST=bots existing webrtc tests.
Review URL: https://codereview.chromium.org/272723006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269354 0039d316-1c4b-4281-b951-d872f2087c98
cc: Add a flag to layers that returns true if the layer is in RSLL.
This patch adds a flag that says whether the layer is currently in RSLL.
Used to remove layers that previously were in RSLL and are no longer
there.
R=enne, danakj
Review URL: https://codereview.chromium.org/265883013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269353 0039d316-1c4b-4281-b951-d872f2087c98
Re-enable SharedModuleServiceUnitTest.WhitelistedImports for windows
BUG=369914
Review URL: https://codereview.chromium.org/272723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269352 0039d316-1c4b-4281-b951-d872f2087c98
Updating trunk VERSION from 1984.0 to 1985.0
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269349 0039d316-1c4b-4281-b951-d872f2087c98
Use ICU alternatives in net/base/filename_util.cc
TEST=build/android/test_runner.py gtest -s net_unittests --gtest_filter=FilenameUtilTest*
BUG=362608
Review URL: https://codereview.chromium.org/269033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269347 0039d316-1c4b-4281-b951-d872f2087c98
Introduce a new framework for back-and-forth tracked preference migration
between Protected Preferences and unprotected Preferences.
Migration from unprotected Preferences to Protected Preferences was previously
done after both stores had been initialized. This was inherently incorrect as
some operations (PrefHashFilter::FilterOnLoad) would occur before the values
had been moved to the proper store. It also introduced a weird method in
PrefHashFilter::MigrateValues which required an independent PrefHashFilter
(backed by a copy of the real PrefHashStore). This after-the-fact migration
caused Settings.TrackedPreferenceCleared spikes when changing a value from
being enforced to not being enforced (as we'd have a MAC, but no value yet in
this store when running FilterOnLoad()) and more importantly it also caused
issue 365769 -- both of these issues highlight the incorrectness of the
current approach.
The migration back from Protected Preferences to unprotected Preferences when
enforcement was disabled was using yet another mechanism which would only kick
in when a given pref was written to (ref. old non-const
SegregatedPrefStore::StoreForKey()).
The new framework intercepts PrefFilter::FilterOnLoad() events for both stores
and does the back-and-forth migration in place before it even hands them back
to the PrefFilter::FinalizeFilterOnLoad() which then hands it back to the
JsonPrefStores (so that they are agnostic to the migration; from their point
of view their values were always in their store as they received it).
Furthermore, this new framework will easily allow us to later move MACs out of
Local State into their respective stores (which is a task on our radar which
we currently have no easy way to accomplish).
The new framework also handles read errors better. For example, it was
previously possible for the unprotected->protected migration to result in data
loss if the protected store was somehow read-only from a read error while the
unprotected store wasn't -- resulting in an in-memory migration only flushed
to disk in the store from which the value was deleted... The new framework
handles those cases, preferring temporary data duplication over potential data
loss (duplicated data is cleaned up once confirmation is obtained that the new
authority for this data has been successfully written to disk -- it will even
try again in following Chrome runs if it doesn't succeed in this one).
BUG=365769
TEST=
A) Make sure all kTrackedPrefs consistently report
Settings.TrackedPreferenceUnchanged across changes from various enforcement
levels (using --force-fieldtrials).
B) Make sure the prefs are properly migrated to their new store (and
subsequently cleaned up from their old store) when changing the
enforcement_level across multiple runs.
C) Make sure prefs are properly migrated in a quick startup/shutdown with a
new enforcement_level and that their old value is properly cleaned up in a
subsequent startup at the same enforcement_level (or re-migrated at another
enforcement_level).
R=bauerb@chromium.org, stuartmorgan@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/257003007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269346 0039d316-1c4b-4281-b951-d872f2087c98
[FileAPI] Clean up WebFileSystemImpl before Blink shutdown
WebFileSystemImpl should not outlive V8 instance, since it may have references to V8.
This CL ensures it deleted before Blink shutdown.
BUG=369525
Review URL: https://codereview.chromium.org/270633009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269345 0039d316-1c4b-4281-b951-d872f2087c98
Refactor HostSetupDialog and HostInstallDialog.
1. Moved all the host installation logic to the HOST_INSTALL step in HostSetupDialog
2. On Windows host installation now occurs before the pin prompt when user enables remote connection.
3. HostInstallDialog now handles both the prompt (Linux/Mac) and non-prompt (windows) scenarios.
4. Renamed onDone and onError in HostInstallDialog to onOk and onCancel. The install prompt doesn't perform any task itself and won't incur any error so onOk an onCancel are better names.
This CL is a precursor to the change that enables automatic host installation for IT2Me on windows.
BUG=134215
Review URL: https://codereview.chromium.org/243993002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269344 0039d316-1c4b-4281-b951-d872f2087c98
Unload all apps / extensions immediately when deleting a profile.
Previously apps could remain running with references to profiles that had been deleted by users, but before the browser shut down and profiles were fully removed. Problems included E.g. opening a link in an app would open a tab in the deleted profile.
BUG=368684
TEST=Manual testing as described on http://crbug.com/368684#c1
Review URL: https://codereview.chromium.org/266343002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269343 0039d316-1c4b-4281-b951-d872f2087c98
Re-enable RepeatedQuickOverscrollGestures test for non-Windows platforms
This flake appears to be windows-only, like the other failing overscroll
tests. After this is confirmed, I'll create a metabug to address all
failing overscroll tests, and try to find an appropriate owner.
BUG=369871
Review URL: https://codereview.chromium.org/279483004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269342 0039d316-1c4b-4281-b951-d872f2087c98