chore!: migrate to node 14 (#1236)

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
googleapis · Jul 28, 2023 · 73bf31f · 73bf31f
1 parent e62f75a
commit 73bf31f
Show file tree

Hide file tree

Showing 39 changed files with 111 additions and 335 deletions.
diff --git a/.github/sync-repo-settings.yaml b/.github/sync-repo-settings.yaml
@@ -9,9 +9,9 @@ branchProtectionRules:
       - "ci/kokoro: System test"
       - docs
       - lint
-      - test (12)
       - test (14)
       - test (16)
+      - test (18)
       - cla/google
       - windows
       - OwlBot Post Processor

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [12, 14, 16, 18]
+        node: [14, 16, 18, 20]
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3

diff --git a/.kokoro/continuous/node12/common.cfg b/.kokoro/continuous/node12/common.cfg
diff --git a/.kokoro/continuous/node12/lint.cfg b/.kokoro/continuous/node12/lint.cfg
diff --git a/.kokoro/continuous/node12/samples-test.cfg b/.kokoro/continuous/node12/samples-test.cfg
diff --git a/.kokoro/continuous/node12/system-test.cfg b/.kokoro/continuous/node12/system-test.cfg
diff --git a/.kokoro/continuous/node12/test.cfg b/.kokoro/continuous/node12/test.cfg
diff --git a/.kokoro/presubmit/node12/common.cfg b/.kokoro/presubmit/node12/common.cfg
diff --git a/.kokoro/presubmit/node12/samples-test.cfg b/.kokoro/presubmit/node12/samples-test.cfg
diff --git a/.kokoro/presubmit/node12/system-test.cfg b/.kokoro/presubmit/node12/system-test.cfg
diff --git a/.kokoro/presubmit/node12/test.cfg b/.kokoro/presubmit/node12/test.cfg
diff --git a/benchmark/bench.ts b/benchmark/bench.ts
@@ -63,8 +63,9 @@ async function doQuery(queryTxt: string) {
       .on('end', () => {
         const timeTotalMilli = new Date().getTime() - startMilli;
         console.log(
-          `"${queryTxt}",${numRows},${numCols},${timeFirstByteMilli /
-            1000},${timeTotalMilli / 1000}`
+          `"${queryTxt}",${numRows},${numCols},${timeFirstByteMilli / 1000},${
+            timeTotalMilli / 1000
+          }`
         );
         resolve();
       });

diff --git a/package.json b/package.json
@@ -5,7 +5,7 @@
   "license": "Apache-2.0",
   "author": "Google LLC",
   "engines": {
-    "node": ">=12.0.0"
+    "node": ">=14.0.0"
   },
   "repository": "googleapis/nodejs-bigquery",
   "main": "./build/src/index.js",
@@ -77,18 +77,20 @@
     "c8": "^8.0.0",
     "codecov": "^3.5.0",
     "discovery-tsd": "^0.3.0",
+    "eslint-plugin-prettier": "^5.0.0",
     "execa": "^5.0.0",
-    "gts": "^3.1.0",
+    "gts": "^5.0.0",
     "jsdoc": "^4.0.0",
     "jsdoc-fresh": "^2.0.0",
     "jsdoc-region-tag": "^2.0.0",
     "linkinator": "^5.0.0",
     "mocha": "^9.2.2",
     "mv": "^2.1.1",
     "ncp": "^2.0.0",
+    "prettier": "^3.0.0",
     "proxyquire": "^2.1.0",
     "sinon": "^15.0.0",
     "tmp": "0.2.1",
-    "typescript": "^4.6.4"
+    "typescript": "^5.1.6"
   }
 }
diff --git a/samples/addColumnLoadAppend.js b/samples/addColumnLoadAppend.js
@@ -42,10 +42,7 @@ function main(
     const schema = 'Name:STRING, Age:INTEGER, Weight:FLOAT, IsMagic:BOOLEAN';
 
     // Retrieve destination table reference
-    const [table] = await bigquery
-      .dataset(datasetId)
-      .table(tableId)
-      .get();
+    const [table] = await bigquery.dataset(datasetId).table(tableId).get();
     const destinationTableRef = table.metadata.tableReference;
 
     // Set load job options

diff --git a/samples/addColumnQueryAppend.js b/samples/addColumnQueryAppend.js
@@ -32,10 +32,7 @@ function main(datasetId = 'my_dataset', tableId = 'my_table') {
     // const tableId = 'my_table';
 
     // Retrieve destination table reference
-    const [table] = await bigquery
-      .dataset(datasetId)
-      .table(tableId)
-      .get();
+    const [table] = await bigquery.dataset(datasetId).table(tableId).get();
     const destinationTableRef = table.metadata.tableReference;
 
     // In this example, the existing table contains only the 'name' column.

diff --git a/samples/deleteTable.js b/samples/deleteTable.js
@@ -30,10 +30,7 @@ function main(datasetId = 'my_dataset', tableId = 'my_table') {
     // const tableId = "my_table";
 
     // Delete the table
-    await bigquery
-      .dataset(datasetId)
-      .table(tableId)
-      .delete();
+    await bigquery.dataset(datasetId).table(tableId).delete();
 
     console.log(`Table ${tableId} deleted.`);
   }

diff --git a/samples/insertRowsAsStream.js b/samples/insertRowsAsStream.js
@@ -34,10 +34,7 @@ function main(datasetId = 'my_dataset', tableId = 'my_table') {
     ];
 
     // Insert data into a table
-    await bigquery
-      .dataset(datasetId)
-      .table(tableId)
-      .insert(rows);
+    await bigquery.dataset(datasetId).table(tableId).insert(rows);
     console.log(`Inserted ${rows.length} rows`);
   }
   // [END bigquery_table_insert_rows]

diff --git a/samples/insertingDataTypes.js b/samples/insertingDataTypes.js
@@ -132,10 +132,7 @@ function main(datasetId = 'my_dataset', tableId = 'my_table') {
     ];
 
     // Insert data into table
-    await bigquery
-      .dataset(datasetId)
-      .table(tableId)
-      .insert(rows);
+    await bigquery.dataset(datasetId).table(tableId).insert(rows);
 
     console.log(`Inserted ${rows.length} rows`);
   }

diff --git a/samples/package.json b/samples/package.json
@@ -10,7 +10,7 @@
   "author": "Google LLC",
   "repository": "googleapis/nodejs-bigquery",
   "engines": {
-    "node": ">=12.0.0"
+    "node": ">=14.0.0"
   },
   "scripts": {
     "test": "mocha --timeout 200000"

diff --git a/samples/relaxColumnLoadAppend.js b/samples/relaxColumnLoadAppend.js
@@ -41,10 +41,7 @@ function main(
     const schema = 'Age:INTEGER, Weight:FLOAT, IsMagic:BOOLEAN';
 
     // Retrieve destination table reference
-    const [table] = await bigquery
-      .dataset(datasetId)
-      .table(tableId)
-      .get();
+    const [table] = await bigquery.dataset(datasetId).table(tableId).get();
     const destinationTableRef = table.metadata.tableReference;
 
     // Set load job options

diff --git a/samples/test/authViewTutorial.test.js b/samples/test/authViewTutorial.test.js
@@ -38,10 +38,7 @@ const bigquery = new BigQuery();
 
 describe('Authorized View Tutorial', () => {
   after(async () => {
-    await bigquery
-      .dataset(datasetId)
-      .delete({force: true})
-      .catch(console.warn);
+    await bigquery.dataset(datasetId).delete({force: true}).catch(console.warn);
     await bigquery
       .dataset(sourceDatasetId)
       .delete({force: true})

diff --git a/samples/test/datasets.test.js b/samples/test/datasets.test.js
@@ -36,10 +36,7 @@ describe('Datasets', () => {
   });
 
   after(async () => {
-    await bigquery
-      .dataset(datasetId)
-      .delete({force: true})
-      .catch(console.warn);
+    await bigquery.dataset(datasetId).delete({force: true}).catch(console.warn);
   });
 
   it('should create a dataset', async () => {

diff --git a/samples/test/models.test.js b/samples/test/models.test.js
@@ -26,7 +26,7 @@ const GCLOUD_TESTS_PREFIX = 'nodejs_samples_tests_models';
 
 const bigquery = new BigQuery();
 
-describe('Models', function() {
+describe('Models', function () {
   // Increase timeout to accommodate model creation.
   this.timeout(300000);
   const datasetId = `${GCLOUD_TESTS_PREFIX}_${uuid.v4()}`.replace(/-/gi, '_');
@@ -65,10 +65,7 @@ describe('Models', function() {
   });
 
   after(async () => {
-    await bigquery
-      .dataset(datasetId)
-      .delete({force: true})
-      .catch(console.warn);
+    await bigquery.dataset(datasetId).delete({force: true}).catch(console.warn);
   });
 
   it('should retrieve a model if it exists', async () => {
@@ -112,29 +109,20 @@ describe('Create/Delete Model', () => {
   });
 
   after(async () => {
-    await bigquery
-      .dataset(datasetId)
-      .delete({force: true})
-      .catch(console.warn);
+    await bigquery.dataset(datasetId).delete({force: true}).catch(console.warn);
   });
 
   it('should create a model', async () => {
     const output = execSync(`node createModel.js ${datasetId} ${modelId}`);
     assert.include(output, `Model ${modelId} created.`);
-    const [exists] = await bigquery
-      .dataset(datasetId)
-      .model(modelId)
-      .exists();
+    const [exists] = await bigquery.dataset(datasetId).model(modelId).exists();
     assert.strictEqual(exists, true);
   });
 
   it('should delete a model', async () => {
     const output = execSync(`node deleteModel.js ${datasetId} ${modelId}`);
     assert.include(output, `Model ${modelId} deleted.`);
-    const [exists] = await bigquery
-      .dataset(datasetId)
-      .model(modelId)
-      .exists();
+    const [exists] = await bigquery.dataset(datasetId).model(modelId).exists();
     assert.strictEqual(exists, false);
   });
 });
diff --git a/samples/test/queries.test.js b/samples/test/queries.test.js
@@ -51,10 +51,7 @@ describe('Queries', () => {
   });
 
   after(async () => {
-    await bigquery
-      .dataset(datasetId)
-      .delete({force: true})
-      .catch(console.warn);
+    await bigquery.dataset(datasetId).delete({force: true}).catch(console.warn);
   });
 
   it('should query stackoverflow', async () => {

diff --git a/samples/test/routines.test.js b/samples/test/routines.test.js
@@ -36,10 +36,7 @@ const bigquery = new BigQuery();
 
 describe('Routines', () => {
   after(async () => {
-    await bigquery
-      .dataset(datasetId)
-      .delete({force: true})
-      .catch(console.warn);
+    await bigquery.dataset(datasetId).delete({force: true}).catch(console.warn);
   });
 
   before(async () => {