fix: [vertexai] make a copy of the list in ChatSession.setHistory() (…

…#10608) PiperOrigin-RevId: 618209294 Co-authored-by: Jaycee Li <jayceeli@google.com>
googleapis · Mar 22, 2024 · 3e3e35a · 3e3e35a
1 parent 3f68001
commit 3e3e35a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/...ogle-cloud-vertexai/src/main/java/com/google/cloud/vertexai/generativeai/ChatSession.java b/...ogle-cloud-vertexai/src/main/java/com/google/cloud/vertexai/generativeai/ChatSession.java
@@ -92,7 +92,7 @@ public ChatSession withSafetySettings(List<SafetySetting> safetySettings) {
     ChatSession rootChat = rootChatSession.orElse(this);
     ChatSession newChatSession =
         new ChatSession(model.withSafetySettings(safetySettings), Optional.of(rootChat));
-    newChatSession.setHistory(history);
+    newChatSession.history = history;
     return newChatSession;
   }
 
@@ -106,7 +106,7 @@ public ChatSession withSafetySettings(List<SafetySetting> safetySettings) {
   public ChatSession withTools(List<Tool> tools) {
     ChatSession rootChat = rootChatSession.orElse(this);
     ChatSession newChatSession = new ChatSession(model.withTools(tools), Optional.of(rootChat));
-    newChatSession.setHistory(history);
+    newChatSession.history = history;
     return newChatSession;
   }
 
@@ -253,7 +253,7 @@ private Optional<ResponseStream<GenerateContentResponse>> getCurrentResponseStre
 
   /** Set the history to a list of Content */
   public void setHistory(List<Content> history) {
-    this.history = history;
+    this.history = new ArrayList<>(history);
   }
 
   /** Sets the current response of the root chat session (if exists) or the current chat session. */